search

gjaldon / heroku-buildpack-phoenix-static

A Heroku buildpack for building Phoenix's static assets
MIT License
230 stars 224 forks source link

Bump node_version to 5.3.0 #14

Closed col closed 8 years ago

col commented 8 years ago

This addresses an issue when trying to compile assets in when using Phoenix 1.1.0.

See https://github.com/phoenixframework/phoenix/issues/1410 for more details.

chrismcg commented 8 years ago

Should this set the npm version to the most recent too?

col commented 8 years ago

Yeah I think you're right. Bumping the node version was enough to fix my problem but they should be upgraded together. I'll update the pull request tonight.

On Monday, January 4, 2016, Chris McGrath notifications@github.com wrote:

Should this set the npm version to the most recent too?

— Reply to this email directly or view it on GitHub https://github.com/gjaldon/heroku-buildpack-phoenix-static/pull/14#issuecomment-168675025 .

seantanly commented 8 years ago

Simply bumping the Node version doesn't seem to work for me when upgrading to Phoenix 1.1.2.

I have raised a separate issue https://github.com/gjaldon/heroku-buildpack-phoenix-static/issues/15.

gjaldon commented 8 years ago

Thanks for the PR @col!