search

gjaldon / heroku-buildpack-phoenix-static

A Heroku buildpack for building Phoenix's static assets
MIT License
230 stars 224 forks source link

do not activate postgres addon by default #19

Closed asymmetric closed 8 years ago

asymmetric commented 8 years ago

makes it hard to use any other db, or no db at all

gjaldon commented 8 years ago

@asymmetric does removing this mean that we will need to manually add postgres as an addon on heroku?

asymmetric commented 8 years ago

Yes, it does. I think that makes sense though. I understand Postgres is the default option in Phoenix, but why force it?

I mean, can it be overridden at the moment? What happens if I manually remove the addon from Heroku? Will the buildpack add it again?

ericmj commented 8 years ago

The addon will only be added when the heroku app is created, still I am +1 for removing this default.

gjaldon commented 8 years ago

Thanks for the PR @asymmetric and for your input @ericmj!