gjaldon / heroku-buildpack-phoenix-static

A Heroku buildpack for building Phoenix's static assets
MIT License
230 stars 224 forks source link

Set node version / npm version from package.json #32

Closed YayC closed 5 years ago

YayC commented 8 years ago

It seems to be a best practice to specify node and npm versions within the package.json itself, under "engines" (see heroku docs on deploying node apps).

gjaldon commented 8 years ago

@YayConnolly thanks for opening this issue. Will look into supporting that with the next week.

gjaldon commented 5 years ago

Closing since this is in reference to the node buildpack from heroku. The current way of setting npm and node versions should be fine and the same with how heroku-buildpack-elixir does it