search

gjaldon / heroku-buildpack-phoenix-static

A Heroku buildpack for building Phoenix's static assets
MIT License
230 stars 224 forks source link

Update default Node from 5 to 6 LTS #53

Closed acconrad closed 7 years ago

acconrad commented 7 years ago

One issue with the current configuration is Node 5 was never an LTS release, so moving this up to 6.9.2 brings it to LTS and the most applicable support for Phoenix applications.

The other major issue is that this release relies on NPM 2, which has a tiered module management system, causing some unwieldy and memory-intensive node applications. NPM 3 has a flat listing of node modules, which significantly reduces the size of some applications.

I discovered this change after trying to use the latest Babel, and running into issues deploying my application to Heroku. Once I split off of this config and opted for LTS, my application was able to deploy and my application size was down quite a bit.

gjaldon commented 7 years ago

Thanks for the PR @acconrad! 💜