gjaldon / heroku-buildpack-phoenix-static

A Heroku buildpack for building Phoenix's static assets
MIT License
229 stars 224 forks source link

heroku build fails when node patch not specified #93

Open OfTheDelmer opened 5 years ago

OfTheDelmer commented 5 years ago

Setting node_version=10.15 in the phoenix_static_buildpack.config led to a heroku build failure:

Downloading and installing node 10.15.3...
       Installing Node 10.15...
mv: cannot stat '/tmp/node-v10.15-linux-x64/*': No such file or directory

Examining the result of tar xzf /tmp/node-v10.15-linux-x64 -C /tmp with ls /tmp we see the following:

node-v10.15-linux-x64.tar.gz node-v10.15.3-linux-x64

Note the extracted folder includes the patch and causes following to fail in when installing node because the node-version does not have the patch specified.

 mv /tmp/node-v$node_version-linux-x64/* $node_dir
prem-prakash commented 5 years ago

same problem here

hashim-sohail commented 3 years ago

@prem-prakash @OfTheDelmer Did you find a fix?

prem-prakash commented 3 years ago

@hashim-sohail I just added the patch version

Grantimus9 commented 3 years ago

Noting that I got the same error:

Installing binaries
Resolving node version 14.7...
Downloading and installing node 14.7.0...
       Installing Node 14.7...
mv: cannot stat '/tmp/node-v14.7-linux-x64/*': No such file or directory
 !     Push rejected, failed to compile Phoenix app.

And resolved it by adding the precise version to my phoenix_static_buildpack.config file in the root of my project directory: node_version=14.7.0