search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Hide does not work on 2.6.4 #219

Closed eddt750 closed 10 years ago

eddt750 commented 10 years ago

the hide option next to an item when selected from the dropdown doesn't work

gjb2048 commented 10 years ago

Duplicate of #216, please wait for next release.

Is this in the version on Moodle.org or the latest code here?

eddt750 commented 10 years ago

This is in the moodle.org version. I’m not sure which part to extract from github for 2.6.4. The master version is dependent upon 2.7

Apologies for duplicating the error report.

Edd Talbot Digital Learning Resource Developer

Blackburn College & University Centre Room TC210 . Futures Centre . St Pauls Street . Blackburn . Lancashire . BB2 1DL . 01254 292109 .

The Blended Learning Team helpline: extn 2109 For further help and inspiration: http://ask.blackburn.ac.ukhttp://ask.blackburn.ac.uk/ How To Moodlehttp://moodle2.blackburn.ac.uk/course/view.php?id=2295

[Description: Description: Description: C:\Users\suml01\AppData\Local\Microsoft\Windows\Temporary Internet Files\Content.Outlook\01A151HO\iLab new sig strip.jpg]

From: Gareth J Barnard [mailto:notifications@github.com] Sent: 29 August 2014 14:18 To: DBezemer/moodle-theme_essential Cc: Edward Talbot Subject: Re: [moodle-theme_essential] Hide does not work on 2.6.4 (#219)

Duplicate of #216, please wait for next release.

Is this in the version on Moodle.org or the latest code here?

— Reply to this email directly or view it on GitHubhttps://github.com/DBezemer/moodle-theme_essential/issues/219#issuecomment-53874121.

The information in this email is confidential and legally privileged, access to this email by anyone else is unauthorised. If you are not the intended recipient of this email please inform the sender immediately and delete the email from your system. Any views or opinions expressed in this email may be personal and do not represent the opinions, views or policies of Blackburn College, or its employees or students.

DBezemer commented 10 years ago

@eddt750 I am working on making a more unified version (at least code wise). Expect the next Essential release in a few days that will solve this for all versions.

gjb2048 commented 10 years ago

Thanks for the information and report Edd as could have been something different.

DBezemer commented 10 years ago

If you want to solve it already, look for the code in 7d569d9655898fad0bb1fdcba5f2bf4f60556d6e

eddt750 commented 10 years ago

I’ll patch it until the full update.

Thanks again for the amazingly quick response, support and help.

Edd Talbot Digital Learning Resource Developer

Blackburn College & University Centre Room TC210 . Futures Centre . St Pauls Street . Blackburn . Lancashire . BB2 1DL . 01254 292109 .

The Blended Learning Team helpline: extn 2109 For further help and inspiration: http://ask.blackburn.ac.ukhttp://ask.blackburn.ac.uk/ How To Moodlehttp://moodle2.blackburn.ac.uk/course/view.php?id=2295

[Description: Description: Description: C:\Users\suml01\AppData\Local\Microsoft\Windows\Temporary Internet Files\Content.Outlook\01A151HO\iLab new sig strip.jpg]

From: David Bezemer [mailto:notifications@github.com] Sent: 29 August 2014 14:42 To: DBezemer/moodle-theme_essential Cc: Edward Talbot Subject: Re: [moodle-theme_essential] Hide does not work on 2.6.4 (#219)

If you want to solve it already, look for the code in 7d569d9https://github.com/DBezemer/moodle-theme_essential/commit/7d569d9655898fad0bb1fdcba5f2bf4f60556d6e

— Reply to this email directly or view it on GitHubhttps://github.com/DBezemer/moodle-theme_essential/issues/219#issuecomment-53876662.

The information in this email is confidential and legally privileged, access to this email by anyone else is unauthorised. If you are not the intended recipient of this email please inform the sender immediately and delete the email from your system. Any views or opinions expressed in this email may be personal and do not represent the opinions, views or policies of Blackburn College, or its employees or students.

DBezemer commented 10 years ago

dont forget to recompile the less files (you can find the package.json and Gruntfile.js in master). Otherwise you will get double icon + image in your menus.