search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Google Web Fonts do not load in quiz #511

Closed sim3083 closed 9 years ago

sim3083 commented 9 years ago

When using Google Web Fonts, evrything works well until you attempt or review an quiz.

Settings test home administration appearance themes essential font

What I want to see test assessment-good

What I see test assessment

I can only think there are some security setting in the quiz module that wont allow access the Google Fonts. I have it working by using custom fonts and uploading the .ttf

I have tried it in Clean theme by adding the link in AdditionalHTML and the style in Custom CSS and it seems to carry over.

Anyway a bug nonetheless (l think!)

gjb2048 commented 9 years ago

Ok,

A) will not be a security setting. B) both screen shots are identical using the theme bar the font, so how did you make the first screen shot?

Sent from my iPod in deep space...

On 23 Jun 2015, at 05:48, Simon notifications@github.com wrote:

When using Google Web Fonts, evrything works well until you attempt or review an quiz.

Settings

What I want to see

What I see

I can only think there are some security setting in the quiz module that wont allow access the Google Fonts. I have it working by using custom fonts and uploading the .ttf

Anyway a bug nonetheless (l think!)

— Reply to this email directly or view it on GitHub.

gjb2048 commented 9 years ago

Scrub B - too early.

Sent from my iPod in deep space...

On 23 Jun 2015, at 05:48, Simon notifications@github.com wrote:

When using Google Web Fonts, evrything works well until you attempt or review an quiz.

Settings

What I want to see

What I see

I can only think there are some security setting in the quiz module that wont allow access the Google Fonts. I have it working by using custom fonts and uploading the .ttf

Anyway a bug nonetheless (l think!)

— Reply to this email directly or view it on GitHub.

gjb2048 commented 9 years ago

Plus, do the other pages work?

Sent from my iPod in deep space...

On 23 Jun 2015, at 05:48, Simon notifications@github.com wrote:

When using Google Web Fonts, evrything works well until you attempt or review an quiz.

Settings

What I want to see

What I see

I can only think there are some security setting in the quiz module that wont allow access the Google Fonts. I have it working by using custom fonts and uploading the .ttf

Anyway a bug nonetheless (l think!)

— Reply to this email directly or view it on GitHub.

gjb2048 commented 9 years ago

Cannot replicate:

2015-06-23 12_27_28-moo28_ administration_ appearance_ themes_ essential_ font 2015-06-23 12_28_57-a quiz 2015-06-23 12_27_48-a quiz

gjb2048 commented 9 years ago

Humm, perhaps a '+' symbol thing.....

2015-06-23 12_34_02-a quiz 2015-06-23 12_31_25-a quiz 2015-06-23 12_36_09-google fonts

gjb2048 commented 9 years ago

No 'Open Sans' being loaded on the network tab.....

gjb2048 commented 9 years ago

Ok, everything in place, so not a bug:

2015-06-23 12_40_10-a quiz 2015-06-23 12_41_09-fonts googleapis com_css_family oswald_open sans subset latin latin-ext

gjb2048 commented 9 years ago

2015-06-23 12_44_11-fonts

sim3083 commented 9 years ago

Hi Gareth

Thanks for looking into this... sorry for the late reply as we are on opposite ends of the earth (Australia).

I haven't noticed any issues in any other plugin/module

The developer tab does not show any errors or missing links to fonts, and the css files load correctly as you have shown above and the rule is setting Oswald and Open Sans, but for some reason the fonts do not load.

If it cannot be replicated then so be it but I thought i would share in case it was a bug.

Regards

S

gjb2048 commented 9 years ago

Hi Simon,

I'm sorry but if I cannot replicate the problem or see fault in the code, there is nothing I can do about it. Unless, are you running on https?

Gareth

gjb2048 commented 9 years ago

Nope, won't be that: https://github.com/gjb2048/moodle-theme_essential/blob/master/layout/includes/fonts.php#L28

gjb2048 commented 9 years ago

Are there any 404 errors on the Network tab?

sim3083 commented 9 years ago

Hey Gareth

No network Errors but it isnt importing the fonts in question, not even an attempt it seems

gjb2048 commented 9 years ago

In that case, I have no idea.

sim3083 commented 9 years ago

Ok no problem...

Thanks for looking into it anyway

S

richardschwarz commented 9 years ago

Something I noticed in other parts was that if one was a google font and the other was looking for a font that's not on the google repository (ie a websafe,local font) then it won't load the google font. On 24 Jun 2015 9:45 am, "Simon" notifications@github.com wrote:

Ok no problem...

Thanks for looking into it anyway

S

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/511#issuecomment-114675811 .

gjb2048 commented 9 years ago

Thanks for that Richard, but if you see the sequence of screen shots above, that statement is false.

Sent from my iPod in deep space...

On 24 Jun 2015, at 01:10, Richard Schwarz notifications@github.com wrote:

Something I noticed in other parts was that if one was a google font and the other was looking for a font that's not on the google repository (ie a websafe,local font) then it won't load the google font. On 24 Jun 2015 9:45 am, "Simon" notifications@github.com wrote:

Ok no problem...

Thanks for looking into it anyway

S

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/511#issuecomment-114675811 .

— Reply to this email directly or view it on GitHub.

gjb2048 commented 9 years ago

P.s. Tested with fonts specified which are both on Google Fonts.

Sent from my iPod in deep space...

On 24 Jun 2015, at 01:10, Richard Schwarz notifications@github.com wrote:

Something I noticed in other parts was that if one was a google font and the other was looking for a font that's not on the google repository (ie a websafe,local font) then it won't load the google font. On 24 Jun 2015 9:45 am, "Simon" notifications@github.com wrote:

Ok no problem...

Thanks for looking into it anyway

S

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/511#issuecomment-114675811 .

— Reply to this email directly or view it on GitHub.

richardschwarz commented 9 years ago

No, that's cool. Checked on google fonts too. They are definitely both there. Interesting. I'm using Google fonts on mine and not getting that issue. On 24 Jun 2015 5:21 pm, "Gareth J Barnard" notifications@github.com wrote:

P.s. Tested with fonts specified which are both on Google Fonts.

Sent from my iPod in deep space...

On 24 Jun 2015, at 01:10, Richard Schwarz notifications@github.com wrote:

Something I noticed in other parts was that if one was a google font and the other was looking for a font that's not on the google repository (ie a websafe,local font) then it won't load the google font. On 24 Jun 2015 9:45 am, "Simon" notifications@github.com wrote:

Ok no problem...

Thanks for looking into it anyway

S

— Reply to this email directly or view it on GitHub < https://github.com/gjb2048/moodle-theme_essential/issues/511#issuecomment-114675811

.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/511#issuecomment-114760291 .