Slide Show broken after upgrade from Moodle 2.8 to 2.9

ghost commented 8 years ago

Hi everyone. I followed the directions exactly for upgrading. The latest 2.9 version of this plugin was installed and was happy to see so many things fixed. But one thing broke badly - it is the slide show! With one item the screen appears to work correctly. With any more than that the items appear consecutively on the screen.

Tried deleting all the items in the show which shows the default images properly and they cycle. Reloaded my images/text/etc. and it breaks again.

At a loss....

gjb2048 commented 8 years ago

The screen shot shows two. When you go back to the settings page what is the number now? When uploading things did you save with the button at the bottom?

3-bits commented 8 years ago

Yes, the rest are disabled. But i tested several pages with the slideshow enable and disabled and always get the error. So it no depends of the page, only from the header.

I removed also missed plugins and the wrong code still there.

I will enable all the slides

3-bits commented 8 years ago

The 2 slides are already enabled

ghost commented 8 years ago

Looks terrible - I know it is getting late for you guys...and I appreciate all you are doing. Thank you.

On Wed, Dec 9, 2015 at 1:27 PM, 3bits notifications@github.com wrote:

The 2 slides are already enabled

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163365078 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Ok, looking at the site now it is the BCU theme, the wrong code:

<css font-awesome.min.css"="" rel="stylesheet" id="yui_3_17_2_2_1449694593144_247">

still remains. Therefore:

That code is not coming from Essential.
Is probably causing the slider JS to break.
Causing the rendering of the slider to go wrong.

Given Essential's header code:

    echo $OUTPUT->standard_head_html();
    ?>
    <meta name="viewport" content="width=device-width, initial-scale=1.0">

and the markup having an injected Google Analytics script:

<css font-awesome.min.css"="" rel="stylesheet" id="yui_3_17_2_2_1449694593144_247">
<script>
  (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
  (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
  m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
  })(window,document,'script','//www.google-analytics.com/analytics.js','ga');

  ga('create', 'UA-8126823-2', 'cellstream.com');
  ga('send', 'pageview');

</script>    <meta name="viewport" content="width=device-width, initial-scale=1.0">

therefore I have concluded that it is the plugin etc. that injecting the analytics script that almost certainly is injecting the rubbish.

ghost commented 8 years ago

OK - removed

On Wed, Dec 9, 2015 at 3:03 PM, Gareth J Barnard notifications@github.com wrote:

Ok, looking at the site now it is the BCU theme, the wrong code:

<css font-awesome.min.css"="" rel="stylesheet" id="yui_3_17_2_2_1449694593144_247">

still remains. Therefore:

That code is not coming from Essential.

Is probably causing the slider JS to break.

Causing the rendering of the slider to go wrong.

Given Essential's header code:
echo $OUTPUT->standard_head_html();
?>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
and the markup having an injected Google Analytics script:

<css font-awesome.min.css"="" rel="stylesheet" id="yui_3_17_2_2_1449694593144_247">
therefore I have concluded that it is the plugin etc. that injecting the analytics script that almost certainly is injecting the rubbish. — Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163391104 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

3-bits commented 8 years ago

Gareth, I removed all the unused plugins in the test site and the issue still continue (I got an error in the debugger and then I removed the plugins). BCU was not installed until Andy did it a few minutes ago so this is not the problem.

I made a search of the string "<css/font-awesome.min.css" in my whole dev server and the string is not found. So I agree with you that some plugin is creating the problem injecting that code that breaks the HTML structure and some classes. The question is to know which one.

ghost commented 8 years ago

Slider still broken

On Wed, Dec 9, 2015 at 3:46 PM, Andrew Walding awalding@gmail.com wrote:

OK - removed

On Wed, Dec 9, 2015 at 3:03 PM, Gareth J Barnard <notifications@github.com
wrote:

Ok, looking at the site now it is the BCU theme, the wrong code:

<css font-awesome.min.css"="" rel="stylesheet" id="yui_3_17_2_2_1449694593144_247">

still remains. Therefore:

That code is not coming from Essential.

Is probably causing the slider JS to break.

Causing the rendering of the slider to go wrong.

Given Essential's header code:
echo $OUTPUT->standard_head_html();
?>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
and the markup having an injected Google Analytics script:

<css font-awesome.min.css"="" rel="stylesheet" id="yui_3_17_2_2_1449694593144_247">
therefore I have concluded that it is the plugin etc. that injecting the analytics script that almost certainly is injecting the rubbish. — Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163391104 .
Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Ok, I need to really think about this and have time to do so. There was a recent change that allowed HTML markup to be injected into the caption. It looks like as a result it is possible to have invalid markup that breaks the structure of the slider. And hence the mess.

ghost commented 8 years ago

OK - returning site to single slide and three marketing spots. Sorry to cause so much trouble. This theme has been spotless until the 2.9 upgrade

and I really wanted to go to 3.x.

On Wed, Dec 9, 2015 at 4:13 PM, Gareth J Barnard notifications@github.com wrote:

Ok, I need to really think about this and have time to do so. There was a recent change that allowed HTML markup to be injected into the caption. It looks like as a result it is possible to have invalid markup that breaks the structure of the slider. And hence the mess.

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163415062 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Ok, I've taken a copy of the markup when broken and will have a look. Very tired.

There will not be a 3.x of the theme until I have a business case to make one.

ghost commented 8 years ago

Thanks for all you do Gareth.

On Wed, Dec 9, 2015 at 4:25 PM, Gareth J Barnard notifications@github.com wrote:

Ok, I've taken a copy of the markup when broken and will have a look. Very tired.

There will not be a 3.x of the theme until I have a business case to make one.

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163419477 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Thanks Andy.

Something well iffy with the markup:

<div id="essentialCarousel" class="carousel slide" data-interval="5000">
  <ol class="carousel-indicators">
   <li data-target="#essentialCarousel" data-slide-to="0" class=""></li>
   <li data-target="#essentialCarousel" data-slide-to="1" class="active"></li>
  </ol>
  <div class="carousel-inner" id="yui_3_17_2_2_1449698528646_235">
   <a href="http://www.cellstream.com/netsci/course/index.php?categoryid=28" target="_self" class="item side-caption">
    <div class="container-fluid">
     <div class="row-fluid">
      <div class="span5 the-side-caption">
       <div class="the-side-caption-content">
        <h4>Network Science Fundamentals Certification Program</h4>
        <p></p>
        <p class="p1">We offer a full Network Science certification program via online videos and testing. To find out more click here!</p>
        <p></p>
       </div>
      </div>
      <div class="span7">
       <div class="carousel-image-container">
        <img src="//cellstream.com/netsci/pluginfile.php/1/theme_essential/slide1image/1449697720/netscicert.png" alt="Network Science Fundamentals Certification Program" class="carousel-image">
       </div>
      </div>
     </div>
    </div>
   </a>
   <a href="http://www.cellstream.com/netsci/course/view.php?id=125" target="_self" class="item side-caption active" id="yui_3_17_2_2_1449698528646_241"></a>
   <div class="container-fluid active" id="yui_3_17_2_2_1449698528646_234">
    <a href="http://www.cellstream.com/netsci/course/view.php?id=125" target="_self" class="item side-caption"></a>
    <div class="row-fluid" id="yui_3_17_2_2_1449698528646_233">
     <a href="http://www.cellstream.com/netsci/course/view.php?id=125" target="_self" class="item side-caption"></a>
     <div class="span5 the-side-caption" id="yui_3_17_2_2_1449698528646_255">
      <a href="http://www.cellstream.com/netsci/course/view.php?id=125" target="_self" class="item side-caption"></a>
      <div class="the-side-caption-content" id="yui_3_17_2_2_1449698528646_254">
       <a href="http://www.cellstream.com/netsci/course/view.php?id=125" target="_self" class="item side-caption" id="yui_3_17_2_2_1449698528646_253">
        <h4 id="yui_3_17_2_2_1449698528646_252">Learn how to install GNS3 v1.x here!</h4>
        <p></p>
       </a>
       <p class="p1" id="yui_3_17_2_2_1449698528646_256">
         <a href="http://www.cellstream.com/netsci/course/view.php?id=125" target="_self" class="item side-caption"></a>
         <a href="http://cellstream.com/netsci/mod/glossary/showentry.php?eid=8762&amp;displayformat=dictionary" title="Our On-Line School of Network Science Glossary of Terms and Acronyms: GNS3" class="glossary autolink concept glossaryid17">GNS3</a> is perhaps the industry best network emulation environment and learning tool. We have used this tool since it's inception, and now with the new 1.x release, we encourage our students to use this tool. Find out how
       </p>
       <p></p>
      </div>
     </div>
     <div class="span7" id="yui_3_17_2_2_1449698528646_240">
      <div class="carousel-image-container" id="yui_3_17_2_2_1449698528646_239">
       <img src="//cellstream.com/netsci/pluginfile.php/1/theme_essential/slide2image/1449697720/gns3.jpeg" alt="Learn how to install GNS3 v1.x here!" class="carousel-image" id="yui_3_17_2_2_1449698528646_251">
      </div>
     </div>
    </div>
   </div>
  </div>
   <a class="left carousel-control" href="#essentialCarousel" data-slide="prev">
    <i class="fa fa-chevron-circle-left"></i>
   </a>
   <a class="right carousel-control" href="#essentialCarousel" data-slide="next" id="yui_3_17_2_2_1449698528646_267">
    <i class="fa fa-chevron-circle-right" id="yui_3_17_2_2_1449698528646_266"></i>
   </a>
  </div>

3-bits commented 8 years ago

Gareth, I will investigate also the issue and try to find the problem. Thanks

gjb2048 commented 8 years ago

Thanks Fernando - odd as this is the only recent change in the code: https://github.com/gjb2048/moodle-theme_essential/commit/084163c450d25ec05c155c86bcf1c0af9b1deab8

gjb2048 commented 8 years ago

BTW Andy - I've heard of GNS3 - had great fun messing with WireShark and using Java to send UDP packets and learning about L2 and L3 devices on my MSc.

gjb2048 commented 8 years ago

This smells like a memory leak on the code: https://github.com/gjb2048/moodle-theme_essential/blob/master/classes/toolbox.php#L179-L248

ghost commented 8 years ago

Looking at some screen shots of my moodle site, I also note that the footer is no longer being properly color coded, BTW. I did not change anything there. Also, the light background behind the slides in slideshow appears to be missing.

On Wed, Dec 9, 2015 at 5:04 PM, Gareth J Barnard notifications@github.com wrote:

This smells like a memory leak on the code: https://github.com/gjb2048/moodle-theme_essential/blob/master/classes/toolbox.php#L179-L248

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163430207 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

If the markup is out of whack then that can break the CSS selectors.

gjb2048 commented 8 years ago

I don't know why there is a closing forward slash here: https://github.com/gjb2048/moodle-theme_essential/blob/master/classes/toolbox.php#L223

gjb2048 commented 8 years ago

Nested 'p's don't work either.

gjb2048 commented 8 years ago

Issue #571 might have caused this.

gjb2048 commented 8 years ago

Ok... I've studied the code and the markup that was produced on the site for hours. Tried to replicate locally and cannot. So.... I'm going to tidy a few things up that I've identified and see if that helps in the next release.

ghost commented 8 years ago

Thanks Gareth. I really appreciate your efforts on this one. I was an early adopter of the Essential theme and will update the new version when it is released with fingers crossed.

On Thu, Dec 10, 2015 at 6:39 AM, Gareth J Barnard notifications@github.com wrote:

Ok... I've studied the code and the markup that was produced on the site for hours. Tried to replicate locally and cannot. So.... I'm going to tidy a few things up that I've identified and see if that helps in the next release.

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163598469 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Thanks Andy, I've even copy / pasted your caption content to see if it will break and nope!

ghost commented 8 years ago

Could it be my version of Java on the server?

On Thu, Dec 10, 2015 at 6:45 AM, Gareth J Barnard notifications@github.com wrote:

Thanks Andy, I've even copy / pasted your caption content to see if it will break and nope!

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163599982 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Absolutely not. Java is no relation of JavaScript. Two completely different technologies. In fact if Moodle was J2EE then it might be a better enterprise product.

BTW if you want a UDP tool for packet sniffing experiments on WireShark for educational use, please see: http://gjbarnard.co.uk/portfolio/udp-sender/ - its free!

ghost commented 8 years ago

Cool - I will add this link to my Wireshark courses....:-)

On Thu, Dec 10, 2015 at 6:52 AM, Gareth J Barnard notifications@github.com wrote:

Absolutely not. Java is no relation of JavaScript. Two completely different technologies. In fact if Moodle was J2EE then it might be a better enterprise product.

BTW if you want a UDP tool for packet sniffing experiments on WireShark for educational use, please see: http://gjbarnard.co.uk/portfolio/udp-sender/ - its free!

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163602420 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Oh! Andy, please could you download and put on your site please :) - limited bandwidth with my hoster and I'm paying for it! :)

gjb2048 commented 8 years ago

I'm happy for you to copy anything on that page information wise to put on your course.

ghost commented 8 years ago

Oh sure - OK. I will not point to your site. I will download it.

On Thu, Dec 10, 2015 at 6:57 AM, Gareth J Barnard notifications@github.com wrote:

I'm happy for you to copy anything on that page information wise to put on your course.

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-163603597 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

I cannot replicate the issue at all, but have tied up the code. Leaving open until after the next release to see if that fixes it.

gjb2048 commented 8 years ago

Released in https://moodle.org/mod/forum/discuss.php?d=324677 to try.

ghost commented 8 years ago

Applied the update - I see a number of things are better!! Thanks. But the slider is still broken :(

On Sun, Dec 13, 2015 at 12:05 PM, Gareth J Barnard <notifications@github.com

wrote:

Released in https://moodle.org/mod/forum/discuss.php?d=324677 to try.

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-164284298 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

In that case I have no idea!

gjb2048 commented 8 years ago

I assume that to deleted the whole Essential folder and replaced it with the new files?

ghost commented 8 years ago

Ah! I did not. I ran the plugin update process.

On Sun, Dec 13, 2015 at 12:33 PM, Gareth J Barnard <notifications@github.com

wrote:

I assume that to deleted the whole Essential folder and replaced it with the new files?

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-164286226 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Ok, I'm testing now on a remote server I have, please hang on then....

Please download from https://moodle.org/plugins/pluginversion.php?id=10044 and update manually to see if that works. Full instructions in Readme.txt file.

gjb2048 commented 8 years ago

Ok, broken remotely, need to think: http://vletest.gjbarnard.co.uk/?redirect=0&theme=essential

gjb2048 commented 8 years ago

Ok, new information.... Having links in the captions breaks it.

ghost commented 8 years ago

YAY! I have links in every one!

On Sun, Dec 13, 2015 at 12:48 PM, Gareth J Barnard <notifications@github.com

wrote:

Ok, new information.... Having links in the captions breaks it.

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-164287281 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Ok Andy, now I know what breaks it and I can replicate, I can now think about it, look in a specific area, and test ideas out. Please give me time.

ghost commented 8 years ago

No problem!

On Sun, Dec 13, 2015 at 12:51 PM, Gareth J Barnard <notifications@github.com

wrote:

Ok Andy, now I know what breaks it and I can replicate, I can now think about it, look in a specific area, and test ideas out. Please give me time.

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-164287470 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Humm, link with slide1url then the slide1caption has a link, so a link in a link probably confusing things!

ghost commented 8 years ago

I removed the links and the slider is working, but not 100%. The background color is not working and for some reason the footer is also wrong - color wise. Just an FYI.

On Mon, Dec 14, 2015 at 5:43 AM, Gareth J Barnard notifications@github.com wrote:

Humm, link with slide1url then the slide1caption has a link, so a link in a link probably confusing things!

— Reply to this email directly or view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/578#issuecomment-164417070 .

Andrew M. Walding CellStream, Inc. Tel & Fax: 866-659-1014 Cell: 214-405-3708 Skype ID: awalding Twitter: @awalding http://www.cellstream.com http://www.netscionline.com

gjb2048 commented 8 years ago

Ok, this is what the PHP outputs:

<div class="carousel-inner centred">
    <a href="https://about.me/gjbarnard" target="_self" class="item side-caption active">
        <div class="container-fluid"><div class="row-fluid">
                <div class="span5 the-side-caption">
                    <div class="the-side-caption-content">
                        <h4>Slide one</h4>
                        <div>The caption with a<br>break or<br>two.</div>
                    </div></div><div class="span7">
                        <div class="carousel-image-container">
                            <img src="//moodle29.chloe/pluginfile.php/1/theme_essential/slide1image/-1/760D_0491_1_ig.jpg" alt="Slide one" class="carousel-image">
                        </div>
                    </div>
            </div>
        </div>
    </a>
    <a href="https://about.me/gjbarnard" target="_self" class="item side-caption">
        <div class="container-fluid">
            <div class="row-fluid">
                <div class="span5 the-side-caption">
                    <div class="the-side-caption-content">
                        <h4>Slide two</h4>
                        <div>
                            <p class="p1">We offer a full Network Science certification program via online videos and testing. <a href="https://about.me/gjbarnard" target="_blank">To find out more click here!</a></p>
                        </div>
                    </div>
                </div>
                <div class="span7">
                    <div class="carousel-image-container">
                        <img src="//moodle29.chloe/pluginfile.php/1/theme_essential/slide2image/-1/760D_0687_sm.jpg" alt="Slide two" class="carousel-image">
                    </div>
                </div>
            </div>
        </div>
    </a>
    <a href="https://about.me/gjbarnard" target="_self" class="item side-caption">
        <div class="container-fluid">
            <div class="row-fluid">
                <div class="span5 the-side-caption">
                    <div class="the-side-caption-content">
                        <h4>Slide three</h4>
                        <div>The caption</div>  
                    </div>     
                </div>
                <div class="span7">
                    <div class="carousel-image-container">
                        <img src="//moodle29.chloe/pluginfile.php/1/theme_essential/slide3image/-1/760D_0968_2_ig.jpg" alt="Slide three" class="carousel-image">
                    </div>
                </div>
            </div>
        </div>
    </a>
    <a href="https://about.me/gjbarnard" target="_self" class="item side-caption">
        <div class="container-fluid">
            <div class="row-fluid">
                <div class="span5 the-side-caption">
                    <div class="the-side-caption-content">
                        <h4>Slide four</h4>
                        <div>The fourth caption</div>
                    </div>        
                </div>
                <div class="span7">
                    <div class="carousel-image-container">
                        <img src="http://moodle29.chloe/theme/image.php?theme=essential&amp;component=theme&amp;image=default_slide" alt="Slide four" class="carousel-image">
                    </div>
                </div>
            </div>
        </div>
    </a>
</div>

and this is what is rendered:

<div class="carousel-inner centred" id="yui_3_17_2_2_1450094574364_399">
    <a href="https://about.me/gjbarnard" target="_self" class="item side-caption">
        <div class="container-fluid">
            <div class="row-fluid">
                <div class="span5 the-side-caption">
                    <div class="the-side-caption-content">
                        <h4>Slide one</h4>
                        <div>The caption with a<br>break or<br>two.</div>
                    </div>
                </div>
                <div class="span7">
                    <div class="carousel-image-container">
                        <img src="//moodle29.chloe/pluginfile.php/1/theme_essential/slide1image/-1/760D_0491_1_ig.jpg" alt="Slide one" class="carousel-image">
                    </div>
                </div>
            </div>
        </div>
    </a>
    <a href="https://about.me/gjbarnard" target="_self" class="item side-caption active"></a>
    <div class="container-fluid active" id="yui_3_17_2_2_1450094574364_398">
        <a href="https://about.me/gjbarnard" target="_self" class="item side-caption"></a>
        <div class="row-fluid" id="yui_3_17_2_2_1450094574364_397">
            <a href="https://about.me/gjbarnard" target="_self" class="item side-caption"></a>
            <div class="span5 the-side-caption">
                <a href="https://about.me/gjbarnard" target="_self" class="item side-caption"></a>
                <div class="the-side-caption-content">
                    <a href="https://about.me/gjbarnard" target="_self" class="item side-caption">
                        <h4>Slide two</h4>
                    </a>
                    <div>
                        <a href="https://about.me/gjbarnard" target="_self" class="item side-caption"></a>
                        <p class="p1"><a href="https://about.me/gjbarnard" target="_self" class="item side-caption">We offer a full Network Science certification program via online videos and testing. </a><a href="https://about.me/gjbarnard" target="_blank">To find out more click here!</a></p>
                    </div>
                </div>
            </div>
            <div class="span7" id="yui_3_17_2_2_1450094574364_396">
                <div class="carousel-image-container" id="yui_3_17_2_2_1450094574364_395">
                    <img src="//moodle29.chloe/pluginfile.php/1/theme_essential/slide2image/-1/760D_0687_sm.jpg" alt="Slide two" class="carousel-image" id="yui_3_17_2_2_1450094574364_394">
                </div>
            </div>
        </div>
    </div>
    <a href="https://about.me/gjbarnard" target="_self" class="item side-caption">
        <div class="container-fluid"><div class="row-fluid">
                <div class="span5 the-side-caption">
                    <div class="the-side-caption-content">
                        <h4>Slide three</h4>
                        <div>The caption</div>
                    </div>
                </div>
                <div class="span7">
                    <div class="carousel-image-container">
                        <img src="//moodle29.chloe/pluginfile.php/1/theme_essential/slide3image/-1/760D_0968_2_ig.jpg" alt="Slide three" class="carousel-image">
                    </div>
                </div>
            </div>
        </div>
    </a>
    <a href="https://about.me/gjbarnard" target="_self" class="item side-caption">
        <div class="container-fluid">
            <div class="row-fluid">
                <div class="span5 the-side-caption">
                    <div class="the-side-caption-content">
                        <h4>Slide four</h4>
                        <div>The fourth caption</div>
                    </div>
                </div>
                <div class="span7">
                    <div class="carousel-image-container">
                        <img src="http://moodle29.chloe/theme/image.php?theme=essential&amp;component=theme&amp;image=default_slide" alt="Slide four" class="carousel-image">
                    </div>
                </div>
            </div>
        </div>
    </a>
</div>

Netbeans complains about the link in a link.

gjb2048 commented 8 years ago

With "I removed the links and the slider is working, but not 100%. The background color is not working and for some reason the footer is also wrong - color wise. Just an FYI." what background colour?

gjb2048 commented 8 years ago

In what way wrong?

gjb2048 commented 8 years ago

Please raise a separate issue with screen shots.

gjb2048 commented 8 years ago

Hi Andy,

Hopefully fixed in: https://github.com/gjb2048/moodle-theme_essential/commit/cb8164cff88914c987d17287dae4b81ee7a1d6db

Please test MOODLE_29 branch from here.

Cheers,

Gareth

gjb2048 / moodle-theme_essential

Slide Show broken after upgrade from Moodle 2.8 to 2.9 #578