search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Accessibility: role=main-content ("Role must be one of the valid ARIA roles") #698

Closed nadavkav closed 8 years ago

nadavkav commented 8 years ago

Axe (chrome accessibility extension tool) report all instances of: <section role="main-content"> (In all layout pages) , as "Role must be one of the valid ARIA roles" (Critical).

Looking at https://www.w3.org/TR/wai-aria/rdf_model.png, it seems that a simple role=main could be appropriate. What do you think?

gjb2048 commented 8 years ago

I think I need to go to sleep and work on this another day.

gjb2048 commented 8 years ago

I also think, how the XXXX did that get there?

gjb2048 commented 8 years ago

And yes, I agree its wrong.

gjb2048 commented 8 years ago

'main' would be the solution.

nadavkav commented 8 years ago

Great. (It's too late over this side of the internet too :smile: , let's call it a day. tomorrow...)

gjb2048 commented 8 years ago

Ok, 'role="main"' already output by '$OUTPUT->main_content();' therefore cannot be twice.

gjb2048 commented 8 years ago

Currently looking at things, that 'section' is pointless.

nadavkav commented 8 years ago

You are right. it make sense.

gjb2048 commented 8 years ago

I'm always correct, except when I'm incorrect.

nadavkav commented 8 years ago

:smile: