search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Header title - Fullname and summary option - language span tags #702

Closed tswilson closed 8 years ago

tswilson commented 8 years ago

In Site Administration / Front Page Settings - content within multilanguage span tags renders appropriately in a Course / Site Summary block on the front page.

When selecting 'Full name and Summary' for Header Title in Themes / Essential / Header, the language tags are not being respected, and both the languages appear side-by-side.

IE: With the site in English the Summary block reads: English... likewise with the site in French it reads: French.

In the spot below my site name with the above option enabled, it reads: EnglishFrench.

Regards,

Trevor

gjb2048 commented 8 years ago

Thanks for the report Trevor,

What version of Essential please? What do you think the solution is?

gjb2048 commented 8 years ago

P.s. can you give me some sample code to test with please.

tswilson commented 8 years ago

Hi, Gareth

Assuming you have English and French languages on your Moodle installation, if you put the following in as the Site Summary you’ll get one or the other based on which language you’re in.

EnglishFrench

I’d bet the text for the Site Summary block is getting pushed through format_text($your_text_here, FORMAT_HTML); to activate the Multilanguage Filter, and not when it gets pulled into the Header.

Hope this helps!

Trevor

From: Gareth J Barnard [mailto:notifications@github.com] Sent: July-27-16 2:33 PM To: gjb2048/moodle-theme_essential Cc: Trevor Wilson; Author Subject: Re: [gjb2048/moodle-theme_essential] Header title - Fullname and summary option - language span tags (#702)

P.s. can you give me some sample code to test with please.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/gjb2048/moodle-theme_essential/issues/702#issuecomment-235677678, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADeJpBeSS4SXfYUkgbFG30Jh6BPf6WxDks5qZ6RSgaJpZM4JWfBZ.

tswilson commented 8 years ago

Ooops, realized I forgot to tell you what version I was on.

3.1.0.5 (Build: 2016061703)

Regards,

Trevor

From: Gareth J Barnard [mailto:notifications@github.com] Sent: July-27-16 2:32 PM To: gjb2048/moodle-theme_essential Cc: Trevor Wilson; Author Subject: Re: [gjb2048/moodle-theme_essential] Header title - Fullname and summary option - language span tags (#702)

Thanks for the report Trevor,

What version of Essential please? What do you think the solution is?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/gjb2048/moodle-theme_essential/issues/702#issuecomment-235677451, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADeJpAGmf36y05XL3Y3QTSdJAtFH-7oEks5qZ6QmgaJpZM4JWfBZ.

gjb2048 commented 8 years ago

Thanks Trevor.