search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Header not displaying correctly in 3.0.1.8 #723

Closed ghrich closed 8 years ago

ghrich commented 8 years ago

Hi Gareth,

Is this still an issue? #704

I've just upgraded my dev site and it seems to be doing something very similar:

Dev Site (running 3.0.1.8) dev

Production Site (running 3.0.1.6) prod

Sorry, I wont be able to give you access to my dev site as its on an internal server not accessible to the Internet... But if there is more info I can give you then please ask.

Thanks,

Richard

gjb2048 commented 8 years ago

Humm:

2016-08-23 16_42_10-start

Not adjacent but social icons are close. What are your font settings please?

gjb2048 commented 8 years ago

Clearly you have replaced the string for 'Social networks' with 'Links', what other changes are there?

gjb2048 commented 8 years ago

Looks like #700 needs careful backporting to M2.9 and M3.0.

ghrich commented 8 years ago

Hi Gareth,

Do you need anymore information?

In regards to changes, all I have done is made some lang changes as noticed and I always change core_renderer.php to display the users username instead of firstname (v3.0.1.6 line 1262)

$usermenu .= html_writer::link($userurl, $userpic.$USER->username.$caret, $userclass);

Header font: Candara Test font: Calibri

Custom css:

page-site-index #region-main {

display: none !important; }

page-site-index.editing #region-main {

display: block !important; }

.navbar .navbar-inner .nav > li.dropdown ul.dropdown-menu > li > a { color: #333; }

.navbar .navbar-inner .nav-collapse .nav > li.dropdown ul.dropdown-menu > li > a { color: #333; }

page-header #headerlogo {

color: #026187;

}

Thats it. If I can be of anymore help please don't hesitate to ask. Thanks.

gjb2048 commented 8 years ago

Will be fixed by #700 backport.