search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Rubric pop-out on assignment grading page doesn't use full height. #737

Closed danmarsden closed 8 years ago

danmarsden commented 8 years ago

on the assignment grading page if you get the rubric to pop-out it doesn't use the full height of the available pop-up rubric grade page

gjb2048 commented 8 years ago

Hi Dan,

I tried to replicate, however even though my test assignments are set to 'Rubric' I cannot find the button to open up the pop-up and be in a position to replicate the problem. Please could you provide the test steps I need in order to do so.

Thanks,

Gareth

danmarsden commented 8 years ago

sure - create an assignment with "grading method" set to "rubric" - Save and display.

Define new rubric (should appear after save and display) add 5 or more criteria to the rubric so that you have a decent list save rubric and make it ready hit grade button to start grading brings up the new grading form with the rubric embedded on the right hand side. click the expand arrows at the top right of the embedded rubric to make it pop-out.

hopefully that's enough? - let me know if you get stuck - thanks!

gjb2048 commented 8 years ago

Thanks for the information Dan, I'll attempt to replicate when I get a moment.

gjb2048 commented 8 years ago

Can replicate thanks and also noticed this:

2016-09-02 17_47_06-start

Too many grains of sand to style.

gjb2048 commented 8 years ago

Down to the 'calc(100% - 54px)' being converted to 'calc(46%)' by the LESS compiler.

gjb2048 commented 8 years ago

http://stackoverflow.com/questions/17904088/disable-less-css-overwriting-calc

danmarsden commented 8 years ago

great - thanks Gareth!