gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Course item action edit menu has redundant padding, in RTL mode #749

Closed nadavkav closed 8 years ago

nadavkav commented 8 years ago

image It's seem like the following selector is missing from the RTL version:

.dir-rtl .moodle-actionmenu.show[data-enhanced] .menu a {
    padding-left: .35em;
    padding-right: .35em;
}

After the:

.dir-rtl .moodle-actionmenu[data-enhanced].show .menu a {
    padding: 2px 28px 2px 1em;
}
nadavkav commented 8 years ago

Also, minor.

gjb2048 commented 8 years ago
.dir-rtl .moodle-actionmenu[data-enhanced].show .menu a {
    padding: 2px 28px 2px 1em;
}

is coming from Bootstrapbase. Thus, probably only an M3.1 issue.

gjb2048 commented 8 years ago

But.....

.moodle-actionmenu.show[data-enhanced] .menu a {
  padding-left: 0.35em;
  padding-right: 0.35em;
  .@{fa-css-prefix} {
    margin-right: 5px;
  }
}

does exist in M3.0 so need to test.

gjb2048 commented 8 years ago

Not a problem as 'flip' technology.

nadavkav commented 8 years ago

Thanks