3 block regions displaying in Edit mode for a 2-column layout

[zahrah-]

Hello Gareth,

It's been a while, I hope all's well on your end.

I've recently upgraded to: Moodle 3.1.2 (Build: 20160912) Essential 3.1.0.8 (Build: 2016061707)

Today when I turned on Edit mode my main block is being compressed to make space for a third column when there are only 2 columns on my course page. This makes it somewhat difficult for editing. See following screenshots:

I've checked the closed issues to see if there's any fix but didn't see anything directly related to the layout change in Edit mode.

If you need any further info let me know.

Thank You.

[gjb2048]

I'm good thank you.

Courses are a three column layout. When editing is on, both of the block regions appear. It used to be that empty columns only appeared when drag and drop, however I changed that because of needing to show where the region was even if empty as blocks can be told where to go.

Need to think.

[gemguardian]

Hi Gareth,

I got the same comment from Petra. She has the upgrade now in her Moodle 2.9 site and she said that before the content page didn't push to the left. She finds it very confusing since all her content now shows in a small area on the left, and that consist alot of scrolling.

Maybe I am off track, but I though there has been an option in Essential that you could say you wanted the content to show left or right - or maybe I am just confused with a different theme.

I have enclosed a picture of her screen - so you can see what happens for her. She is using Grid as a courseformat.

[gjb2048]

Hi Gemma,

There is the 'layout' setting which means that it will revert to the block, content, block layout. However, given the description that would not solve the content / scrolling issue.

I think I need to change the complicated logic that the outline box does not appear for a region when empty and only when drag / drop or it has blocks.

G

[gemguardian]

Hi gareth,

I have tried that setting – or at least I think you mean the setting to use the “orginal” layout. And that doesn’t work indeed.

Goodluck!

Gemma

Van: Gareth J Barnard [mailto:notifications@github.com] Verzonden: donderdag 6 oktober 2016 16:03 Aan: gjb2048/moodle-theme_essential moodle-theme_essential@noreply.github.com CC: gemguardian gemma@ltnc.nl; Comment comment@noreply.github.com Onderwerp: Re: [gjb2048/moodle-theme_essential] 3 block regions displaying in Edit mode for a 2-column layout (#751)

Hi Gemma,

There is the 'layout' setting which means that it will revert to the block, content, block layout. However, given the description that would not solve the content / scrolling issue.

I think I need to change the complicated logic that the outline box does not appear for a region when empty and only when drag / drop or it has blocks.

G

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gjb2048/moodle-theme_essential/issues/751#issuecomment-251970381 , or mute the thread https://github.com/notifications/unsubscribe-auth/APyvf-CVVEvt30yzT8lBvBDFOAATw_xtks5qxP-AgaJpZM4J_lwJ . https://github.com/notifications/beacon/APyvf3BLTpfHJ_uLiIfcrONjll2uMDFVks5qxP-AgaJpZM4J_lwJ.gif

[gjb2048]

Fixed in https://github.com/gjb2048/moodle-theme_essential/commit/02f8e8509a59676aa6d0fa408f2bbb5bc5c71fe1

[zahrah-]

Thank you!