search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Accessibility: missing aria-label attribute in "socialicon" elements #755

Closed nadavkav closed 7 years ago

nadavkav commented 8 years ago

A11Y

gjb2048 commented 8 years ago

Not needed as already has 'title' attribute.

nadavkav commented 8 years ago

It seems so, reading the spec, but I still got errors while checking it with WAVE and AXE. Adding the aria-label, which precedes "title", solved it. Your call, by I have to keep it as we are being audited for accessibility and it shows on the report. (Didn't check it yet with a proper screen reader)

gjb2048 commented 8 years ago

Ok then, need screen shot evidence :)

gjb2048 commented 7 years ago

Hi Nadav,

Please provide screen shot evidence of report to convince me.

G

nadavkav commented 7 years ago

I will

gjb2048 commented 7 years ago

Challenge accepted? :)

nadavkav commented 7 years ago

This is WAVE report, after taking the "fix" off: image

nadavkav commented 7 years ago

(btw, I was asked to move the social icons to the footer, from the header. but this was also happening on the header, of course)

gjb2048 commented 7 years ago

Thanks Nadav, snag is the solution is inefficient as its calling get_string twice for the same thing. Better to store the result and reuse.

nadavkav commented 7 years ago

Right again :smile: (updating...)

nadavkav commented 7 years ago

Updated