Create 'top-block' region with optionality setting.

[nadavkav]

I found that it is less scary for teachers to see a smaller empty "Page top" block region when they switch to edit mode on main course view and inside modules (just after finish adding a new module)

I have changed min-height to 20px

.editing.empty-region-footer-left #block-region-footer-left, .editing.empty-region-footer-middle #block-region-footer-middle, .editing.empty-region-footer-right #block-region-footer-right, .editing.empty-region-hidden-dock #block-region-hidden-dock, .editing.empty-region-home #block-region-home, .editing.empty-region-page-top #block-region-page-top, .editing.empty-region-side-post #block-region-side-post, .editing.empty-region-side-pre #block-region-side-pre, .editing.used-region-footer-left #block-region-footer-left, .editing.used-region-footer-middle #block-region-footer-middle, .editing.used-region-footer-right #block-region-footer-right, .editing.used-region-hidden-dock #block-region-hidden-dock, .editing.used-region-home #block-region-home, .editing.used-region-page-top #block-region-page-top, .editing.used-region-side-post #block-region-side-post, .editing.used-region-side-pre #block-region-side-pre {
    min-height: 20px;

How about it?

[gjb2048]

Working on a different idea Nadav, thanks anyway.

[nadavkav]

Cool

Just letting you know that everyone that sees those new/extra blocks areas is very excited! and most commonly ask for another wider block area (above all content and other blocks regions) so they can drag special blocks that can display images (image galleries), various navigation blocks and other unique course information blocks. so you know :smile:

[gjb2048]

Working on fixing: https://github.com/gjb2048/moodle-theme_essential/issues/751.

I get mixed reactions about page top block region.

If you'd like another 'top-block' region then only two hours work.

[nadavkav]

I would love to fund this new/extra "header" block region. And just to make it more clear, to what I am aiming for, here is a mockup:

btw, If users do not like those new/extra regions... maybe you can enable/disable them with a settings? (As far as I am concerned... there's no going back :wink: )

[gjb2048]

Ok, call it 'top-block'. All pages? A setting would make it 2.5 hours because of the testing. Would you like me to send you my terms of business please Nadav?

Also other settings for such have been asked for: https://github.com/gjb2048/moodle-theme_essential/issues/734

[gjb2048]

Or would you prefer 'header-block'? But, possibly that might be confusing with the header itself. Ok, it is technically possible to put it in the header, but that may cause grief.

[gjb2048]

And happy if backported to M3.0 / M2.9?

[nadavkav]

Yes. to all your above comments. Except... do not put it in the real HEADER just above id="page-content". Or maybe you think it is better above id="page-top-header" ? (Hard for me to decide)

[nadavkav]

Do you think we should move these last comments into a new issue?

[gjb2048]

I think the region should be just below 'page-top-header' then would be underneath the breadcrumb.

I'm going to change the nature of the issue to be the enhancement it has turned out to be.

[nadavkav]

Great. Thanks.

[gjb2048]

Hi Nadav,

I think its there bar the back-porting and integration into master.....

Please test the branch when you like: https://github.com/gjb2048/moodle-theme_essential/compare/master_%23770.

Kind regards,

Gareth

[nadavkav]

Looks great! Testing... (As our "Yom Kippur - no talking to anyone and only doing meditation" holiday has officially over :smile: )

[gjb2048]

Thanks Nadav,

Please let me know how it goes :).

& :).

Cheers,

Gareth

[nadavkav]

Again, looks great. Found two tiny issues:

[gjb2048]

Hi Nadav,

The no dashed borders are intentional after complaints. They appear as soon as you start to drag and drop or they have blocks in them.

With the labels, this is a separate issue to address on its own.

Cheers,

Gareth

[nadavkav]

I see. Indeed, originally, they are very high/large and confusing especially if they are empty. but I already shorten them (locally) to 20px and everyone seems happy now. Anyway, I think I will add them locally. as our teachers need to see them to get inspired by the option to move blocks around. (maybe... in 10 years I will hide them again ;-)

BTW, so why not hide the "right" and "left" block regions too? (until drag starts)

The label issue is minor, as it get "fixed" after switching off the edit mode.

So as far as I am concerned, we are done :smile: ! Super cool and thank you for this feature. Nadav

[gjb2048]

Hi Nadav,

Thank you. Just need to merge and back-port to complete the job.

RE: BTW, so why not hide the "right" and "left" block regions too? (until drag starts) - good idea, so note to self: yui3-dd-drop-active-valid for another issue.

I'll document the other issues tomorrow.

Cheers,

Gareth