search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Add IDs to navbar menus #785

Closed nadavkav closed 8 years ago

nadavkav commented 8 years ago

To enable easier CSS styling

(And maybe consider migrating .messagemenu & .usermenu into IDs ? if it does not mess up the current styling too much. only for consistency)

gjb2048 commented 8 years ago

Hi Nadav,

If there is a specific well thought out need for this then I will consider adding it. However as it currently stands its making more grains of sand to style. It also increases the size of the output. I believe in refactoring and reducing the amount of stuff as much as possible to reusable OO theory based components. This goes in the opposite direction.

G

nadavkav commented 8 years ago

I was trying to play around with the position of the various menu icons on the navbar, and looking at the code, it seemed inconsistent (IDs and Classes). Maybe refactoring is too much. but making it more consistent is probably a good idea.

Anyways, if you think it is too much, ignore it. As I am able to use the current classes to style what I need.

gjb2048 commented 8 years ago

Hi Nadav,

If there is a specific well thought out need for this then I will consider adding it. However as it currently stands its making more grains of sand to style. It also increases the size of the output. I believe in refactoring and reducing the amount of stuff as much as possible to reusable OO theory based components. This goes in the opposite direction.

G