search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Hidden grade items in user report not clear as such. #794

Closed bjodau closed 7 years ago

bjodau commented 7 years ago

I'm using Moodle 3.1.2 (Build: 20160912) and Essential 3.1.1.4 (Build: 2016061713).

In user report the hidden grade items are not shaded/dimmed as the even rows in the list are overridden with another color. This is causing some confusion for our teachers.

course_view The course view

user_report User report view where not all hidden items are dimmed/shaded

gjb2048 commented 7 years ago

This area is a nightmare to style, so they are italic instead.

gjb2048 commented 7 years ago

Additional. If I work out a different colour from the settings then that sometimes works, however then can lead to potential ARIA contrast issues. Or I could have a dimmed colour setting times five for the alternative colour schemes. But that is quite a bit of work. Would you find it please?

gjb2048 commented 7 years ago

And I'd have to work out the effect of the dimmed colour in relation to the striped colour in other tables that is not applied to the grade book because its a nightmare to style and was better to keep lack of striping in its case. Hence the complexity of the problem. So to work all of this out would probably take 3.5 to 7 hours to get it correct and tested.

bjodau commented 7 years ago

Thank you for your fast respons, much appreciated!

I reliease I'm probably not the first with this thought/question, but I didn't find any information about it. I wanted to know whether this is something to stay or if you plan on future versions to have the hidden grade items dimmed/shaded as the odd rows so it's coherent?

gjb2048 commented 7 years ago

As I said above I'm going with the 'italic' solution.

bjodau commented 7 years ago

Ok, thank you for your time!

//B

gjb2048 commented 7 years ago

As per #805 will go with 'strike-through' too.

gjb2048 commented 7 years ago

Changed to 'Bug' for strike-through. If shading required then will be an enhancement - raise separate issue please.

ActionJONA commented 7 years ago

I know this is closed but just thought I'd throw in our solution to this problem...

We simply use the closed eye font-awesome icon (and dim and italicise): screen shot 2017-02-15 at 10 38 28 We use this for hidden courses (in my courses dropdown), items, everything. It keeps things consistent and easily identifiable.

gjb2048 commented 7 years ago

Hi Jona,

Interesting solution. But.... it looks annoying to me with the icons out of alignment. If they were at the end then possibly, but then it would be confused with the editing option. Perhaps better to have a totally different icon.

Kind regards,

Gareth