My courses scroll not working. - Githubissues

gjb2048 / moodle-theme_essential

The Essential Moodle Theme

https://gjb2048.github.io/moodle-theme_essential/

GNU General Public License v3.0

91 stars 120 forks source link

My courses scroll not working. #802

Closed gjb2048 closed 7 years ago

gjb2048 commented 7 years ago

Regression caused in: https://github.com/gjb2048/moodle-theme_essential/commit/ed4250968ecd9a039d7d6956ba1a6c91e1f64a53. Intended for 'My Courses' when no sub-menu's to still have limit.... but did not happen. Now can see that need to limit sub-menu's too.

Solution:

Add setting to turn on / off.
Implementation behaves differently if sub-menu's are on / off. When 'Off' then limit menu overflow-y and height as before. When 'On' don't limit menu (otherwise sub-menu's don't display) but do limit the sub-menu itself.

gjb2048 commented 7 years ago

Related to #773.