search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Add icon replacements for t/message and t/addcontact #812

Closed Dagefoerde closed 7 years ago

Dagefoerde commented 7 years ago

Moodle 3.2 has a new message center. We need a FontAwesome replacement for t/message in order to make it look nicer as well as more consistent. I suggest fa-envelope-o.

Before: before

After: after

This has an effect on user/profile.php since t/message is used there, too. I think that using a FontAwesome replacement there improves this page as well. However, for consistency we have to replace t/addcontact; I suggest fa-address-card-o.

Before: before-profile

After: after-profile

What do you think? :) Best wishes

gjb2048 commented 7 years ago

Thanks Jan, I'll consider the patch.

gjb2048 commented 7 years ago

Hi Jan,

Ok, I disagree with the envelope as that implies eMail and given the conversation on: https://tracker.moodle.org/browse/MDL-57419 would be misleading. Therefore perhaps 'fa-comment-o'?

G

Dagefoerde commented 7 years ago

Hi Gareth, Thanks for your consideration. I chose the envelope because that is the icon you used in the navigation bar. I merely did not want to introduce another icon for the same thing. I do get your point, though. What do you think of fa-comments-o? That is the icon you use within the messaging menu for each conversation. We could reuse that.

gjb2048 commented 7 years ago

fa-comments-o sounds good and better than my suggestion.

Dagefoerde commented 7 years ago

Thanks, I updated the branch accordingly.

Profile: profile-next

Messages: messages-next

Best wishes and good night Jan