search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Incorrect header closing tags in header title area. #817

Closed nidamanx closed 7 years ago

nidamanx commented 7 years ago 
----------------------- classes/output/core_renderer.php -----------------------
index 7ad0106..e9a4a0d 100644
@@ -2239,2 +2239,2 @@ class core_renderer extends \core_renderer {
-                                    array('context' => context_course::instance(SITEID))).'</h2>';
-                    $title .= '<h2 id="subtitle">'.format_text($SITE->summary).'</h3>';
+                                    array('context' => context_course::instance(SITEID))).'</h1>';
+                    $title .= '<h2 id="subtitle">'.format_text($SITE->summary).'</h2>';
@@ -2244,2 +2244,2 @@ class core_renderer extends \core_renderer {
-                                    array('context' => context_course::instance(SITEID))).'</h2>';
-                    $title .= '<h2 id="subtitle">'.format_text($SITE->summary).'</h3>';
+                                    array('context' => context_course::instance(SITEID))).'</h1>';
+                    $title .= '<h2 id="subtitle">'.format_text($SITE->summary).'</h2>';
gjb2048 commented 7 years ago

Thanks for reporting this Davide, it is a bug. Cheers, Gareth.

nidamanx commented 7 years ago

Perfect! :-) I think I could find some more things to improve. And, if you like, I would like to contribute also in accessibility optimization