Site summary in the header: element div not allowed as child of element h2 in this context.

[nidamanx]

Hi, I found something we could fix

----------------------- classes/output/core_renderer.php -----------------------
index e9a4a0d..efc072e 100644
@@ -2240 +2240 @@ class core_renderer extends \core_renderer {
-                    $title .= '<h2 id="subtitle">'.format_text($SITE->summary).'</h2>';
+                    $title .= '<h2 id="subtitle">'.format_string($SITE->summary).'</h2>';
@@ -2245 +2245 @@ class core_renderer extends \core_renderer {
-                    $title .= '<h2 id="subtitle">'.format_text($SITE->summary).'</h2>';
+                    $title .= '<h2 id="subtitle">'.format_string($SITE->summary).'</h2>';

http://w3c.github.io/html/single-page.html#the-div-element

[gjb2048]

Hi Davide,

Please explain why the solution is correct.

G

[gjb2048]

Related to #702.

[gjb2048]

Don't worry, worked it out for myself.

[gjb2048]

Test data in site summary:

<p><span lang="en" class="multilang">M3.2 dev site - EN</span><span lang="fr" class="multilang">M3.2 dev site - FR</span></p>

[nidamanx]

So, Gareth, do you need more infos or the fix is right also in your side?

[gjb2048]

No thanks Davide.