gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Flat navigation does not show if blocks were previously docked #827

Closed mkpelletier closed 7 years ago

mkpelletier commented 7 years ago

Moodle 3.3+ Essential 3.3.0.2 (Build: 2017040301)

It appears that the flat navigation is hidden if a user previously had his blocks docked. This can be remedied by first turning off flat navigation, then undocking the blocks. The flat navigation can be enabled. However, I would assume this would have to be done for every user or via an update query.

gjb2048 commented 7 years ago

Can replicate if a block in the same region as Flat Navigation is docked. Cannot replicate scenario described yet.

gjb2048 commented 7 years ago

empty-region-side-pre is added to body class. Humm.

gjb2048 commented 7 years ago

Note: Can override body css classes method but there is some JS changing it on load.

gjb2048 commented 7 years ago

lib/yui/src/dock/js/dock.js resizeBlockSpace is being a pain.