search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Course page hides blocks in Flat Navigation and editing off #830

Closed martinvivek closed 7 years ago

martinvivek commented 7 years ago

The blocks are hidden in the course pages and creates more gaps in pages. is some setting i have to enabled or I am doing anything wrong.

Moodle 3.3+ (build : 20170601) Essentail 3.3.0.3 (Build: 2017040302) Downloaded from github

In Disabled Flat Navigation state

image

In Enabled Flat Navigation state

image

Turned Editing ON

image

gjb2048 commented 7 years ago

Umm, this looks like a customised installation as there is no docking. What customisations do you have please?

martinvivek commented 7 years ago

theme is not edited, just downloaded and installed, have custom css but it may not an issue i removed custom css (not related to theme) and saved purge caches through web and cli. then tried same issue.

When i open quiz it showing blocks (and other pages too showing)

image

martinvivek commented 7 years ago

Sorry, what customization is refer to? Like theme editing or anything else.

gjb2048 commented 7 years ago

Screen shots show no docking and yet should have = thus something going on.

gjb2048 commented 7 years ago

What other contributed modules do you have installed?

gjb2048 commented 7 years ago

Cannot replicate, please provide the 'Properties' file with the 'Export properties as a JSON string' button.

martinvivek commented 7 years ago

sorry for late reply... theme.txt

martinvivek commented 7 years ago

In plugins ->blocks -> manage blocks-> Navigation block is disabled (core plugin) In plugins ->blocks -> manage blocks-> Site Administration is disabled (core plugin)

open the quiz you can see the empty space for the blocks

gjb2048 commented 7 years ago

Do you mean 'Administration' and not 'Site Administration'?

gjb2048 commented 7 years ago

Ok can replicate with 'layout' setting off and no blocks on the course page at all. Flat navigation is on.

gjb2048 commented 7 years ago

Body tag has 'used-region-side-pre' but is 'empty' when change to Clean on same course.

gjb2048 commented 7 years ago

Ok, logic flaw between 'body_css_classes' and 'essential_blocks' in the overridden core_renderer.php.

gjb2048 commented 7 years ago

M3.3 only issue.

martinvivek commented 7 years ago

Issue has been resolved in the course page but in the quiz page still the space are there. With block_navigation and Administration is Disabled

The screenshot with flat navigation enabled. image With flat navigation disabled image

gjb2048 commented 7 years ago

Ok, technically this is a new issue as this is 'Course page' - is the same true in the Clean theme?

gjb2048 commented 7 years ago

Ok, cannot now replicate extra space on the right when editing is on (the 'Left' is showing) and 'layout' setting is true.