User tour with backdrop alignment off

[mnods]

essential 3.2.1.1 moodle 3.2.3 user tour for /course/view.php% one tour step points to ID custom_menu_courses backdrop off - points to correct ID, with it on the tour step gets aligned to centre, highlighting the wrong element.

I also have some weirdness happening in a different step, with or without backdrop - text in the step not displaying properly - looks like it needs a line height.

neither issue appeared when using clean or boost.

[gjb2048]

Thanks for the report.

How do I replicate the problem please? I've not used user tours before.

[mnods]

site admin > appearance > user tours create a new tour give it a name in the Apply to URL match field use /course/view.php% show with backdrop = YES leave others default save head back to main user tours page - admin/tool/usertours/configure.php click on the item you just created add a new step title "user menu" css selector = .usermenu title = User Menu content = This is the user menu which displays on all of your pages. It contains links to your Dashboard, Messages, Profile, and your Preferences.

head to a course main page and the user tour should appear. you can reset to start again via the rest link in the footer.

[mnods]

... so you could add new steps to this tour for various other selectors eg #custom_menu_courses and others in main tour settings, alter backdrop setting to see difference in placement of the tour step on the course page.

[gjb2048]

Thanks, added to list of jobs, probably sometime in July.

[mnods]

nice on gareth, thanks.

[gjb2048]

Target type = Selector?

[gjb2048]

Caused by:

.navbar .navbar-inner {
    line-height: 0;
}

[gjb2048]

Not in M3.3.

[gjb2048]

Testing instructions do not state how to replicate first issue.

[gjb2048]

Cannot replicate either issue in M3.1.

[gjb2048]

Can replicate first issue in M3.2.

[gjb2048]

In M3.3 the first issue is off but not by much.

[gjb2048]

Actually ditto for M3.2.

[gjb2048]

Ok I think that the first issue is down to user tours being confused about the navbar not being at the top but changing position. Not sure I can solve that.

[gjb2048]

In M3.2 the #custom_menu_courses issue jumps around from when you've done 'Next' step to reloading with it showing. Or rather if you've scrolled down the page.

[gjb2048]

Ok I can replicate the first issue with being 'off' in the Clean theme if the '.langmenu' is targeted on the navbar as it's within a '.collapse' -> core issue for that. So far in M3.2 and M3.3 but not M3.1.

[gjb2048]

Not actually sure why 'line-height: 0' is there, removing for now in M3.2 and M3.3.

[gjb2048]

Ok, up to you to raise MDL tracker issue.