search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Help icons open a new tab #833

Closed tonyjbutler closed 7 years ago

tonyjbutler commented 7 years ago

Just testing the latest version for 3.3 and clicking Moodle's context help icons opens a new tab rather than a modal dialogue.

gjb2048 commented 7 years ago

Latest version? Which version please?

tonyjbutler commented 7 years ago

Yes, 2017040302.

gjb2048 commented 7 years ago

Can replicate, no idea why its not working though.

gjb2048 commented 7 years ago

Note: Running M3.2 version on M3.3 gets same issue, so nothing changed in the theme at the moment, so must be some sort of core API change as M3.2 version ok on M3.2.

tonyjbutler commented 7 years ago

This is the fella: https://github.com/moodle/moodle/commit/f745b81201735b5bc094a0a4fb17910a0c952660

gjb2048 commented 7 years ago

Thank you Tony :)

gemguardian commented 7 years ago

Gareth, the issue is also in M3.1

gjb2048 commented 7 years ago

Hi Gemma,

I can't reproduce on M3.1.

G

gemguardian commented 7 years ago

Sorry I had an issue with Help, thought it was the same. But it was "Help" in the user menu, if I place emailadress there.

gjb2048 commented 7 years ago

Hi Gemma,

If I complete the 'helplink' theme setting with an eMail address then it correctly creates a 'mailto' link. So not sure what the issue is?

G

gjb2048 commented 7 years ago

M3.3 only.