search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Secure layout broken #836

Closed martinvivek closed 6 years ago

martinvivek commented 7 years ago

In Manage Blocks i have disabled the Block_navigation and Administration but in Flat Navigation the blocks still showing. if flat navigation disabled its disappears. Is it intentionally kept? Yes means you can close this issue.

martinvivek commented 7 years ago

essential Version : 201704030 moodle version : Moodle 3.3+ (Build: 20170601)

gjb2048 commented 7 years ago

I don't actually understand what you are saying?

martinvivek commented 7 years ago

If i disabled the blocks, it should not show in the pages right. I disabled the administration and navigation blocks. and it is not showing if the flat navigation is disabled. the below screenshot not shows the naviagation block.

image

if i enabled the flat navigation, navigation and Site administration menu is displaying in the pages even it is in disabled state

image

The screenshot shows the quiz page but is appearing in course page also.

gjb2048 commented 7 years ago

On https://user-images.githubusercontent.com/7712010/28050767-43da31e4-661d-11e7-8166-a2b6ed6acab8.png the area with 'Silo assessment' is the 'Flat navigation' - so confused by what you are saying.

gjb2048 commented 7 years ago

With "If i disabled the blocks, it should not show in the pages right" it should show "Next page" as that is a quiz thing and nothing to do with the navigation block.

gjb2048 commented 7 years ago

Still confused about this!

martinvivek commented 7 years ago

1. For other pages: The Flat Navigation Block should not appear on the pages when the navigation and administration is disabled in manage blocks. (as it wont show when the flat navigation is disabled)

2. For quiz pages The Flat Navigation Block Should not appear on the quiz page also because i selected do not show blocks in quiz settings. So only quiz navigation should display (referencing #835)

To reproduce : 1 Disable the Administration and navigation block in Plugin overview ->>Manage blocks Disable Flat navigation and see the course pages no blocks will be there Enable Flat navigation and see the navigation block is appeared with Site Administration Menu

To reproduce : 2 Create a quiz. in quiz setting -->appearance ->Show blocks during quiz attempts ->"NO" Disable Flat navigation and see the quiz pages no blocks will be there except quiz navigation Enable Flat navigation and see the navigation block is appeared and below that quiz navigation blocks appear ( referencing #835)

gjb2048 commented 7 years ago

Ok,

For '1' you are wrong as when the navigation and settings blocks in Boost are disabled then the flat navigation is still shown. In fact now in Essential this is 'broken' argh!

For '2' do not show blocks option seems to be broken in both Boost and Clean, so please raise with Moodle HQ via the tracker.

Therefore nothing on this for me to fix but rather fix something that was not broken.

martinvivek commented 7 years ago

image

Fresh Moodle installation with only essential theme Plugin. (no Custom CSS code)

Created New Course Added New Quiz Added two questions - one with image one without Image Quiz Settings Attempt 1

Every thing is working fine as per your feedback.

But when i Enable Browser security Problem occurs.

image

Switch role to Student and attempt the quiz, you can see the gap on the right side and quiz navigation occurs in left.

In clean theme Everything is perfect image

Essential :3.3.1.1 (Build: 2017040305) Moodle : 3.3.1+ (Build: 20170824)

gjb2048 commented 7 years ago

Note to self, do not back-port solution but see if in M3.2- there is an issue and consider separate solution as all to do with layouts etc. and they have changed.

gjb2048 commented 6 years ago

Still an issue?

gjb2048 commented 6 years ago

No reply so assuming not.