Icons missing and/or out of alignment on certain pages

[tonyjbutler]

In Moodle 3.3.1 with Essential 3.3.0.3 (latest code from master):

• On Assignment pages the editing icons in both the navbar actionmenu and the settings block are all missing.

• On the course Participants page the navbar actionmenu items are out of alignment and some of their icons are missing.

[gjb2048]

Latest from GitHub as from the changes of last night?

[tonyjbutler]

Yes, I've just pulled those in the hope they would include the fix.

[gjb2048]

A fix for a specific issue? If so, which one please Tony?

[tonyjbutler]

No, I just made sure I pulled the latest commits before reporting this issue, in case some other fix happened to have fixed this too.

[gjb2048]

So was this an issue I did not know about?

[tonyjbutler]

I couldn't find another report for it.

[gjb2048]

So it is another issue I was not aware of? Did you notice it before I changed to the new notifications and messaging menu system in the navbar which pulls in the 'plugin' custom menu?

[gjb2048]

Or I might be wrong as could be the 'context_header_settings_menu' which was there before. Also in Boost there is an issue with missing icons.

[tonyjbutler]

As far as I can tell this is an issue that you were not previously aware of. I noticed it before pulling last night's commits, but wanted to double check that I was running the latest code before reporting it. So I pulled, cleared the caches, verified that it was still an issue and then reported it.

[gjb2048]

Ok, so is Flat Navigation off please? And thanks for reporting.

[tonyjbutler]

Yes, flat navigation off.

[gjb2048]

With the assignment pages the icons are missing in Boost, so a core issue for that:

[tonyjbutler]

Aha, OK.

[gjb2048]

So in Essential this will be true of the Administration menu. Issue looks like icon replacement as classes have 'fa-fw fa-fw' and no icon class.

[tonyjbutler]

Yes, I'd been trying to work out what 'fa-fw' meant, as there is no such icon.

[tonyjbutler]

So Essential is based on BS4 now?

[gjb2048]

fa-fw is a FontAwesome helper class. BS4? Why do you say and think that?

[tonyjbutler]

Because it is inheriting Boost issues.

[gjb2048]

Boost participants:

[gjb2048]

Boost is not just BS4 its templating and PHP etc. with the FontAwesome icon system, so nothing to do with BS4 but everything to do with the generation of the markup.

[tonyjbutler]

Right, OK.

[tonyjbutler]

So this will be fixed by a core fix.

[gjb2048]

This smells of one core change.

[gjb2048]

It would only be fixed by core if:

a) They know about it. b) It can be replicated in a core thing - Boost.

[gjb2048]

Marked as core issue but I'll see if I can fix locally. And I'm not happy with the alignments anyway.

[tonyjbutler]

Thanks Gareth.

[gjb2048]

Note to self:

.block_navigation .block_tree p.hasicon { text-indent: -21px; padding-left: 21px; <----- }

M3.3 and M3.2 not M3.1.

[gjb2048]

Ok, stupid change to 'fa-fw' was made in https://tracker.moodle.org/browse/MDL-58808 -> https://github.com/moodle/moodle/commit/57ea73d02c0d431060c282a885e8c5852c12f5ba#diff-a4dcc10cfefa7c3fa24a187a61283fa1.

[gjb2048]

Do you have a Moodle tracker account Tony?

[tonyjbutler]

Sure do.

[gjb2048]

In that case, please would you be so kind as to raise an issue about the missing icons on the Boost theme in relation to it being a regression caused by MDL-58808 as pragmatically I think I'm perceived by Damyon as a 'pain in the ****' so he'll no longer take any notice of me.

[tonyjbutler]

OK, will do. ;-)

[gjb2048]

Thank you :) - please do let me know the MDL and I'll vote for it.

[gjb2048]

BTW, its only M3.3 and master issue. MDL-58808 only went there.

[tonyjbutler]

Cheers.

[tonyjbutler]

https://tracker.moodle.org/browse/MDL-59545

[gjb2048]

Hi Tony,

I've worked out a local fix to put the icon back. Testing ATM.

G