gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

OpenGraph Markup Description #840

Open vvhof opened 7 years ago

vvhof commented 7 years ago

Summary

Moodle is not generating certain information that would allow other application to generate a website preview.

If a website is shared via its URL on Slack, Skype, Whatsapp or Facebook, said clients derive a preview representation based upon information provided in OpenGraph Markup.

More Information: OpenGraph Markup

Details

Steps to Reproduce

  1. Go to Facebook Debug Tool
  2. Insert Moodle instance URL

...or share in Slack, Skype, etc.

Expected Result

A preview representation of the Moodle website including a title, a short description and an image.

Actual Result

No preview is generated.

Environment

Linux with 4.4.0-83-generic skypeforlinux 5.3.0.1 Slack 2.6.3 64-bit Beta Channel

# Warnings That Should Be Fixed | -- The 'og:url' property should be explicitly provided, even if a value can be inferred from other tags. The 'og:title' property should be explicitly provided, even if a value can be inferred from other tags. The 'og:description' property should be explicitly provided, even if a value can be inferred from other tags. The 'og:image' property should be explicitly provided, even if a value can be inferred from other tags. from Facebook Debug Tool

gjb2048 commented 7 years ago

Ok, interesting, why should I spend my time on this?

gjb2048 commented 7 years ago

And looking at http://ogp.me/ - why should this not be a core rather than an Essential thing?

vvhof commented 7 years ago
<html prefix="og: http://ogp.me/ns#">
<head>
<title>The Rock (1996)</title>
<meta property="og:title" content="The Rock" />
<meta property="og:type" content="video.movie" />
<meta property="og:url" content="http://www.imdb.com/title/tt0117500/" />
<meta property="og:image" content="http://ia.media-imdb.com/images/rock.jpg" />
</head>
</html>

As the change required appears as meta information in the page title, i had assumed it to be a theme 'thing'. If the head is already constructed by the core, i suppose it would indeed be a core 'thing'

gjb2048 commented 7 years ago

Hi Vincent,

That's not what I meant. I'm talking about the 'why' and 'where' not the how. If it should be done then the 'where' should probably be core so that all Moodle installations have it without every contributed theme having to update.

So please kindly state 'why' this should be done.

Kind regards,

Gareth

gjb2048 commented 6 years ago

Hi Vincent,

Please provide further information as requested or I'll close this.

Kind regards,

Gareth

vvhof commented 6 years ago

Hello Gareth,

If you agree with the 'why', I'd kindly ask for your opinion on the 'where'. Otherwise consider this closed.

Best regards, Vincent