search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Would it be possible to change a private to a protected? #842

Closed Tazoeur closed 7 years ago

Tazoeur commented 7 years ago

Hi, First of all, I'd like to thank you for the great work you do on this theme plugin.

I am currently overriding the function custom_menu_user() by extending your \theme_essential\output\core_renderer.

The problem I have is that the private function getfontawesomemarkup() is used in the custom_menu_user() function.

I can bypass the problem by copy/pasting the function getfontawesomemarkup() inside my renderer but If you could change the visibility of this function from private to protected, it will make things easier and IMHO improve the usability of this class.

Regards, Guillaume

Tazoeur commented 7 years ago

Here is a patch :) change_visibility_core_renderer.patch.txt

gjb2048 commented 7 years ago

Hi Guillaume,

I see no problem with this. What version of Essential are you running please?

G

Tazoeur commented 7 years ago

Hi G,

I currently use the version 2017040305 (release 3.3.1.1)