gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

categoryincoursebreadcrumbfeature doesn't work if navshowcategories is disabled #845

Closed tonyjbutler closed 7 years ago

tonyjbutler commented 7 years ago

I'm guessing the category data just isn't available with navshowcategories disabled, but is there any way around this?

tonyjbutler commented 7 years ago

This is in Moodle 3.3.1 with Essential 3.3.1.0 (Build: 2017040304) by the way.

navshowcategories is a core config setting in /admin/settings.php?section=navigation

gjb2048 commented 7 years ago

Any way around this = no bar Moodle tracker to change get_items() in /lib/navigationlib.php to accept a parameter that overrides $CFG->navshowcategories. Or this global is changed by the theme when the setting 'categoryincoursebreadcrumbfeature' is used, but that then breaks the intent of 'navshowcategories'.