gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Flip main content and blocks, RTL mode. #850

Closed nadavkav closed 6 years ago

nadavkav commented 6 years ago

Switching from LTR to RTL, should mirror the content area and the blocks areas (columns) in RTL mode, on all theme modes (Legacy blocks and the new "Nav drawer")

For theme settings: flatnavigation = off & layout = off This is how it should be: image

For theme settings: flatnavigation = off & layout = on This is how it should be: image

For theme settings: flatnavigation = on & layout = on This is how it should be: image

nadavkav commented 6 years ago

Suggested all-rtl CSS outcome fix for rtl mode: .row-fluid [class="span"] { float: left; } [class="span"].pull-right, .row-fluid [class*="span"].pull-right { float: right; } But since Moodle 3.3 is auto flipping LTR css selectors, it should obviously be the exact opposite in the actual code.

gjb2048 commented 6 years ago

So Nadav, is it the same core issue as https://tracker.moodle.org/browse/MDL-60250 where the auto-flip technology is changing the nature of a selector attribute when it should not?

gjb2048 commented 6 years ago

Therefore a 'core' issue as 'pull-right' no longer means what it says. As regardless of LTR or RTL, right is right and left is left, unless you're looking in a mirror!

nadavkav commented 6 years ago

Yep. unless there is a special /rtl: ... / comments in the CSS/SCSS code (https://docs.moodle.org/dev/CSS_Coding_Style#Right-to-left)

gjb2048 commented 6 years ago

Therefore as a Bootstrap class in Bootstrapbase then core needs to change.

gjb2048 commented 6 years ago

And I know about https://docs.moodle.org/dev/CSS_Coding_Style#Right-to-left as otherwise how could I have submitted the patch for MDL-60250? ;)

gjb2048 commented 6 years ago

Hi Nadav,

As MDL-60250 is closed, is this still an issue?

G

nadavkav commented 6 years ago

Hi Gareth, Unfortunately, it did not. as it was only related to popover. Nadav

nadavkav commented 6 years ago

BTW, looking forward seeing you on the 2018 UK MoodleMOOT at Glasgow

gjb2048 commented 6 years ago

Thinking this is an M3.3+ only issue.