Fixed accesibility issue: missing alt attribute in site logo.

gjb2048 / moodle-theme_essential

The Essential Moodle Theme

https://gjb2048.github.io/moodle-theme_essential/

GNU General Public License v3.0

91 stars 120 forks source link

Fixed accesibility issue: missing alt attribute in site logo. #852

Closed carreraj closed 6 years ago

carreraj commented 6 years ago

Today i realized that img tag for site logo is missing alt attribute. Looking at Boost theme I saw they use site's shortname for alt, so I'm sending you this pull request.

gjb2048 commented 6 years ago

Thanks Juan,

How do you know they've implemented it correctly? Is there specific evidence that dictates that this is a problem? e.g. a report from http://wave.webaim.org/ ?

Gareth

gjb2048 commented 6 years ago

Also, is the site shortname really descriptive of the image? I don't think so. Therefore a better solution is a setting with the logo where the user can enter a description. As imagine a screen reader describing the logo (say an image of a 'Boat') as 'MyMoodleSite'? What does that convey to the user = nothing meaningful.

gjb2048 commented 6 years ago

Raised #853.