search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Site logo needs textual description for accessibility #853

Closed gjb2048 closed 6 years ago

gjb2048 commented 6 years ago

Ref: https://github.com/gjb2048/moodle-theme_essential/pull/852

gjb2048 commented 6 years ago

Solve with setting where the user can enter text.

carreraj commented 6 years ago

Hi Gareth, I realized of missing attribute because of http://wave.webaim.org/ report. I agree with you that shortname is not descriptive. Probably "Site logo" fixed string is enough, and a specific setting is complete and definitive solution. Thank you very much for your awesome work.

Juan

gjb2048 commented 6 years ago

Ok started to do this, then read "The text should explain where the link goes if the image is inside an element" on https://www.w3schools.com/tags/att_img_alt.asp - therefore! The link already has the description.

gjb2048 commented 6 years ago

Therefore just need:

alt="'.get_string('home').'"

instead of a setting!

gjb2048 commented 6 years ago

Please advise.

carreraj commented 6 years ago

Thank you, Gareth.