search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

add README.md and let README.txt point out README.md #869

Closed jjangga0214 closed 6 years ago

jjangga0214 commented 6 years ago

In order to apply benefits of using markdown even with cares for already existing links and mentions to README.txt, I added not just README.md but modify content of README.txt to guide readers to read READMD.md. So external links to README.txt will work, and visitors will understand the situation.

P.S. In my opinion, markdown is quite necessary.
For example, the "text" in README.txt file below, is really cumbersome to get information without proper rendering.

![image1](pix/screenshot.jpg "Essential Screenshot")
[![Build Status](https://travis-ci.org/gjb2048/moodle-theme_essential.svg?branch=master)](https://travis-ci.org/gjb2048/moodle-theme_essential)
gjb2048 commented 6 years ago

Currently Essential is released all the way back to Moodle 3.3 - https://moodle.org/plugins/theme_essential. Please could you provide respective pull requests which include single commits - so i.e. one commit per branch to contain the change in such. There are two here and there needs to be only one.

jjangga0214 commented 6 years ago

Now this PR contains only 1 commit (2 commits rebased to 1).

By the way, if this question is proper, what do you mean below, and why?

Currently Essential is released all the way BACK to Moodle 3.3

gjb2048 commented 6 years ago

Thanks for the single patch.

So I mean, please provide pull requests with changes for the Moodle 3.4 and 3.3 branches too, with the correct respective alterations.

jjangga0214 commented 6 years ago

I added two consistent PRs each for branch Moddle_33(#872) and Moddle_34(#873).