search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

embed-responsive bootstrap class not supported? #883

Open mkpelletier opened 6 years ago

mkpelletier commented 6 years ago

Hi Gareth,

I am loving the theme as always. Essential has come such a long way since the 2.X branch. :-)

I know essential does support some bootstrap classes already, but it seems embed-responsive and embed-responsive-item (bootstrap 4 classes supported in boost) does not seem to work on the latest version of essential. Just so you have the full picture, I am trying to put scorm presentation inside an iframe so I can avoid the default ugly moodle box icon. To this end, I would normally do:

` < d i v class="embed-responsive embed-responsive-16by9">

< / d i v > `

Is there a better way to do this in Essential?

Here are my system particulars:

Moodle version: Moodle 3.5.3+ (Build: 20181113) Essential version: 3.5.1.1 (Build: 2018051902)

Thanks again for the help!

mkpelletier commented 6 years ago

Pardon the funny div elements. Github refused to render my codebock with a normal div tag, so I had to edit it!

gjb2048 commented 6 years ago

Hi Mathieu,

It seems that theme\boost\scss\bootstrap\utilities_embed.scss is in BS4 and not BS2.3.2. Essential is a child theme of Bootstrapbase which is B2.3.2 and hence does not have them. Therefore the solution is to convert the SCSS _embed.scss to LESS and put them it the theme.

Kind regards,

Gareth

gjb2048 commented 6 years ago

M3.5 -> https://moodle.org/mod/forum/discuss.php?d=379017