search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Extra whitespace added in navigation block when using AJAX #888

Closed alex-rowe closed 5 years ago

alex-rowe commented 5 years ago

When opening the site administration menu from the site home page where it is defaulted to closed, there is an extra bit of white space added beside the FontAwesome icons when they are rendered. This is when the admin branch is rendered with AJAX using getsiteadminbranch.php.

capture

When opening it from another page, such as settings, where it is already loaded, there are no pieces of extra white space added.

In the markup, it looks like there has been a new line/carriage return added, but I can't find where in the theme this rendering is taking place.

capture1

This is when flat navigation is turned off, and it does not occur in Clean as that theme is using IMG tags rather than FontAweome.

Moodle Version 3.5.3 (20181112) Essential Version 3.5.1.2 (2018051903)

gjb2048 commented 5 years ago

M3.3 version no longer being developed, closing.