gemguardian
commented
5 years ago Hi Steve
You probably misser the forum message Gareth put up. But Essential will not be upgrades too 3.7 due too the theme changes that HQ.
Verzonden vanaf mijn Samsung Galaxy-smartphone.
-------- Oorspronkelijk bericht -------- Van: oursteve notifications@github.com Datum: 28-07-19 20:43 (GMT+01:00) Aan: gjb2048/moodle-theme_essential moodle-theme_essential@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Onderwerp: [gjb2048/moodle-theme_essential] Essential not compatible with Moodle 3.7 (#896)
Hi I upgraded Moodle without checking the Essential version (my bad) and broke it, receiving a 500 error, oops. I have reverted to version 3.6.5 and now all is well. I have posted this just for information when considering an update or anyone else has the same error.
Code: Fatal error: Access level to theme_essential\output\core_renderer::build_action_menu_from_navigation() must be protected (as in class core_renderer) or weaker in /home/xxxxxxxx/public_html/theme/essential/classes/output/core_renderer.php on line 49
It seems that in:
/home/xxxxxx/public_html/theme/essential/classes/output/core_renderer.php
function was private but it should have been public, so on line 634 I changed:
private function build_action_menu_from_navigation(action_menu $menu, navigation_node $node, $indent = false,
to
public function build_action_menu_from_navigation(action_menu $menu, navigation_node $node, $indent = false,
and the website is now working, however it displays Essential theme not compatible. I hope this assists anyone. Steve
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/gjb2048/moodle-theme_essential/issues/896?email_source=notifications&email_token=AD6K672BUY5LMYATWGSP62DQBXSGJA5CNFSM4IHNFA72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HB5GWLQ, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD6K67YQVCJ6OB3TCWP4FZTQBXSGJANCNFSM4IHNFA7Q.
gjb2048
oursteve
Hi I upgraded Moodle without checking the Essential version (my bad) and broke it, receiving a 500 error, oops. I have reverted to version 3.6.5 and now all is well. I have posted this just for information when considering an update or anyone else has the same error.
3.7 error: Code: Fatal error: Access level to theme_essential\output\core_renderer::build_action_menu_from_navigation() must be protected (as in class core_renderer) or weaker in /home/xxxxxxxx/public_html/theme/essential/classes/output/core_renderer.php on line 49
It seems that in:
/home/xxxxxx/public_html/theme/essential/classes/output/core_renderer.php
function was private but it should have been public, so on line 634 I changed:
private function build_action_menu_from_navigation(action_menu $menu, navigation_node $node, $indent = false,
to
public function build_action_menu_from_navigation(action_menu $menu, navigation_node $node, $indent = false,
and the website is now working, however it displays Essential theme not compatible. I hope this assists anyone. Steve