search

gjb2048 / moodle-theme_shoehorn

Shoehorn theme for Moodle with the underlying Bootstrap v3 theme.
Other
3 stars 6 forks source link

Ordered/Unordered list not showing #25

Closed hartmut1s closed 8 years ago

hartmut1s commented 8 years ago

Hi Gareth,

Using Atto, I can't see the numbers of an ordered list or the bullet points with Shoehorn 3.1.0.1 (2016072100) in Moodle 3.1.1 (Build: 20160811). The first screenshot is taken from Shoehorn, the second from Clean. number missing in ordered list - shoehorn number showing in ordered list - clean theme

With kind regards, Hartmut

gjb2048 commented 8 years ago

Appears to be missing margin CSS for some reason.

gjb2048 commented 8 years ago

BS3 seems to have lost side margin values: https://github.com/twbs/bootstrap/blob/v3.3.7/less/type.less#L157-L166 -> https://github.com/twbs/bootstrap/blob/v2.3.2/less/type.less#L105-L108

gjb2048 commented 8 years ago

Hi Hartmut,

Fixed in https://github.com/gjb2048/moodle-theme_shoehorn/commit/3f176b6ff26bb474e5f99e416da9f16c0fb83a37 and will be in the next release.

G

hartmut1s commented 8 years ago

Hi Gareth,

Thank you for the fix. You are very fast. It's just amazing and very encouraging to see how you maintain the theme.

With kind regards, Hartmut

On Wed, Aug 24, 2016 at 3:41 AM, Gareth J Barnard notifications@github.com wrote:

Hi Hartmut,

Fixed in 3f176b6 https://github.com/gjb2048/moodle-theme_shoehorn/commit/3f176b6ff26bb474e5f99e416da9f16c0fb83a37 and will be in the next release.

G

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gjb2048/moodle-theme_shoehorn/issues/25#issuecomment-241813962, or mute the thread https://github.com/notifications/unsubscribe-auth/AH4RCmJJANInIEY89eaEJ-tVzVpOuf_pks5qizDZgaJpZM4Jq2JT .

gjb2048 commented 8 years ago

No worries Hartmut.