search

gjb2048 / moodle-theme_shoehorn

Shoehorn theme for Moodle with the underlying Bootstrap v3 theme.
Other
3 stars 6 forks source link

Unordered list not showing in Dataform activity description #27

Closed hartmut1s closed 8 years ago

hartmut1s commented 8 years ago

Hi Gareth,

We use the Moodle plugin Dataform. In a Dataform activity, an unordered list is not displayed with Shoehorn, but I can see it in Clean.

With kind regards, Hartmut

hartmut1s commented 8 years ago

It's a problem with margins again. It's barely visible in the screenshot below. ul in dataform

gjb2048 commented 8 years ago

Hi Hartmut,

Ok, initially, no M3.1 version: https://moodle.org/plugins/pluginversions.php?plugin=mod_dataform.

G

gjb2048 commented 8 years ago

Hi Hartmut,

Installed the module but have no idea how to replicate the issue. Please provide instructions / test course.

Thanks,

Gareth

hartmut1s commented 8 years ago

Hi Gareth,

After I reported the missing ol/ul in Dataform, I saw that ol/ul is also missing in the assignment activity. My best guess is that the code gets overridden, because when I added ul, ol { margin-left: 25px; } in custom CSS, the display is correct.

If you still need or want to replicate the issue in Dataform, start a new Dataform activity, save it without changing anything and select preset. I uploaded a preset at https://www.dropbox.com/s/x9g9zdi94tabbu4/Journal_%28For_at_least_10_days%29-dataform-preset-20160828_2131-without-user-data.mbz?dl=0 If you load it into the Dataform activity and apply the preset, you should see a description in the Overview view without ol/ul.

With kind regards, Hartmut

gjb2048 commented 8 years ago

So the assignment issue is a separate one?

gjb2048 commented 8 years ago

Hi Hartmut,

I'm sorry, but I'm still lost! Please could you provide step by step instructions on how to replicate. This is what I have in the Clean theme with the view of the preset (so that I'd see the list and know its there):

2016-08-29 20_50_49-start

G

gjb2048 commented 8 years ago

Also please provide a screenshot and instructions for the assignment issue in a new issue, I'm lost as cannot see a list there either.

hartmut1s commented 8 years ago

Not a bug as I found out when I tested the activity at my test site. Probably I didn't install the latest version of Shoehorn correctly. I will do this again. Sorry for the confusion.