browser window size effects content visibility

sestrauss commented 8 years ago

Hi Gareth,

Thanks for your SUPER FAST help with the "Block visibility issue with block, content, block layout. #23" issue. I'm not sure if this is the same issue, or a new one, but content is or is not be visible, depending upon how people size their browser windows. Course blocks often disappear, and occasionally header content too. I see this in all browsers. I have attached a zip with a couple of screen casts.

Thanks for looking into this. -Sharon Shoehorn visibility issues.zip

gjb2048 commented 8 years ago

What version of Moodle and Shoehorn please?

sestrauss commented 8 years ago

Moodle 3.0.5 Shoehorn 3.0.1.3 (2015112411)

gjb2048 commented 8 years ago

On to-do list.

sestrauss commented 8 years ago

Thanks!

On Wed, Sep 21, 2016 at 11:14 AM, Gareth J Barnard <notifications@github.com

wrote:

On to-do list.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gjb2048/moodle-theme_shoehorn/issues/29#issuecomment-248643724, or mute the thread https://github.com/notifications/unsubscribe-auth/AFQ-ikZBe56iINKNEJJQBwluBMvhOm37ks5qsUnugaJpZM4KC5rV .

Sharon Strauss Instructional Technology Services IITS Haverford College http://iits.haverford.edu sstrauss@haverford.edu 610-896-4916

IITS staff will never ask for your password. The privacy of your password enhances the privacy of our entire community and the integrity of our technology environment. Check us out on the web - http://www.haverford.edu/iits Read our blog - http://iits.haverford.edu/instructionaltechnology/

gjb2048 commented 8 years ago

I'm sure I've seen this before somewhere! Humm. Might have fixed something in M3.1 and not backported to M3.0.

sestrauss commented 8 years ago

Just in case it helps, this is a copy of the same Bio 200 course, but with the bootstrap theme. bio200 course with bootstrap.mp4.zip

gjb2048 commented 8 years ago

Ta.

gjb2048 commented 8 years ago

Hi Sharon,

Ok, on https://moodle.haverford.edu/ - you have modified the theme to have blocks on the left instead of the right. This change is causing the issue. As its not my fault then if you'd like me to help then I'll gladly send you my terms of business with my development / support rates.

Kind regards,

Gareth

sestrauss commented 8 years ago

Hi Gareth,

Thanks.

I had the _theme_shoehorn | landflayout setting set to "block, content, block". Changing that setting to the default "_Content, Block, Block" setting does solve the problem.

I do see your note "Layout order. Second block area only if specified in 'config.php'." for that setting.

So it sounds like I have the following options:

change the landflayout setting to the default
- change my config.php file to enable the right blocks or change the default to be just left
live with the problem
hire you to fix the issue

Is that a correct understanding?

On Wed, Sep 21, 2016 at 1:56 PM, Gareth J Barnard notifications@github.com wrote:

Hi Sharon,

Ok, on https://moodle.haverford.edu/ - you have modified the theme to have blocks on the left instead of the right. This change is causing the issue. As its not my fault then if you'd like me to help then I'll gladly send you my terms of business with my development / support rates.

Kind regards,

Gareth

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gjb2048/moodle-theme_shoehorn/issues/29#issuecomment-248691405, or mute the thread https://github.com/notifications/unsubscribe-auth/AFQ-ihWRsPi0ove3Bb2pxLK0ff3nzrL6ks5qsW-_gaJpZM4KC5rV .

Sharon Strauss Instructional Technology Services IITS Haverford College http://iits.haverford.edu sstrauss@haverford.edu 610-896-4916

IITS staff will never ask for your password. The privacy of your password enhances the privacy of our entire community and the integrity of our technology environment. Check us out on the web - http://www.haverford.edu/iits Read our blog - http://iits.haverford.edu/instructionaltechnology/

gjb2048 commented 8 years ago

Hi Sharon,

Ok, forgotten about that setting as have so many themes, if I can replicate locally then I'll fix.

Options are:

I identify an issue with the theme as supplied, then will fix. Or....
You work out what's wrong with your changes and fix them yourself. Or....
Live with the issue. Or....
Hire me to help you.

G

sestrauss commented 8 years ago

Thanks. I just looked at my config.php file and did not find anything that seemed relevant to this issue.

On Wed, Sep 21, 2016 at 2:34 PM, Gareth J Barnard notifications@github.com wrote:

Hi Sharon,

Ok, forgotten about that setting as have so many themes, if I can replicate locally then I'll fix.

G

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gjb2048/moodle-theme_shoehorn/issues/29#issuecomment-248702122, or mute the thread https://github.com/notifications/unsubscribe-auth/AFQ-ijWHue9OAz6OJWR5eWbZQl92-1fSks5qsXidgaJpZM4KC5rV .

Sharon Strauss Instructional Technology Services IITS Haverford College http://iits.haverford.edu sstrauss@haverford.edu 610-896-4916

IITS staff will never ask for your password. The privacy of your password enhances the privacy of our entire community and the integrity of our technology environment. Check us out on the web - http://www.haverford.edu/iits Read our blog - http://iits.haverford.edu/instructionaltechnology/

gjb2048 commented 8 years ago

Ok, 'landflayout' setting of 'Block, Content, Block' works correctly locally in version 3.01.4, being the next version with:

  1. Fix: Block visibility issue with block, content, block layout - #23.
  2. Fix: Marketing spots in child themes.
  3. Fix: Temporary fix until MDL-55185 is fixed in core.

Which, looking at: https://github.com/gjb2048/moodle-theme_shoehorn/compare/V3.0.1.3...MOODLE_30 has changes to fix the issue but I've not released them yet.

However:

You've already reported this in #23, which I then fixed.
You've tried to solve the problem yourself and the changes have not worked.

gjb2048 commented 8 years ago

NTS: Changes are in M3.1 version.

gjb2048 commented 8 years ago

So, I just need to release the theme on Moodle.org plugins db and you update and remove your changes. I'll find some time soon.

gjb2048 commented 8 years ago

Also... I'm only human, honest, so do forget things and make mistakes! If it had transpired that I'd charged you for my time and then found it was my fault I would have returned the money.

sestrauss commented 8 years ago

Gareth,

Thank you!

No criticism. I appreciate all the great themes you make available to our community! https://github.com/gjb2048/moodle-theme_shoehorn/issues/23

On Wed, Sep 21, 2016 at 2:50 PM, Gareth J Barnard notifications@github.com wrote:

Also... I'm only human, honest, so do forget things!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gjb2048/moodle-theme_shoehorn/issues/29#issuecomment-248706597, or mute the thread https://github.com/notifications/unsubscribe-auth/AFQ-imy8hdXa8KwTak3Ua2aLt_FthP_eks5qsXxrgaJpZM4KC5rV .

Sharon Strauss Instructional Technology Services IITS Haverford College http://iits.haverford.edu sstrauss@haverford.edu 610-896-4916

IITS staff will never ask for your password. The privacy of your password enhances the privacy of our entire community and the integrity of our technology environment. Check us out on the web - http://www.haverford.edu/iits Read our blog - http://iits.haverford.edu/instructionaltechnology/

gjb2048 commented 8 years ago

Hi Sharon,

Released: https://moodle.org/plugins/pluginversion.php?id=12272.

Kind regards,

Gareth

sestrauss commented 8 years ago

Hi Gareth,

Works like a charm!

Thank you.

Sharon

On Thu, Sep 22, 2016 at 6:24 PM, Gareth J Barnard notifications@github.com wrote:

Hi Sharon,

Released: https://moodle.org/plugins/pluginversion.php?id=12272.

Kind regards,

Gareth

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gjb2048/moodle-theme_shoehorn/issues/29#issuecomment-249045996, or mute the thread https://github.com/notifications/unsubscribe-auth/AFQ-iqM_gj1PuSf60VS92QKXhMLl0Ww9ks5qswA4gaJpZM4KC5rV .

Sharon Strauss Instructional Technology Services IITS Haverford College http://iits.haverford.edu sstrauss@haverford.edu 610-896-4916

IITS staff will never ask for your password. The privacy of your password enhances the privacy of our entire community and the integrity of our technology environment. Check us out on the web - http://www.haverford.edu/iits Read our blog - http://iits.haverford.edu/instructionaltechnology/

gjb2048 / moodle-theme_shoehorn

browser window size effects content visibility #29