search

gjb2048 / moodle-theme_shoehorn

Shoehorn theme for Moodle with the underlying Bootstrap v3 theme.
Other
3 stars 6 forks source link

Strict standards issue with user menu #9

Closed mike-grant closed 9 years ago

mike-grant commented 9 years ago

I've just downloaded the latest version for Moodle 2.7 (2.7.1.1) from Moodle.org and installed it for the first time.

Throws a strict standards error with the user menu,

Strict Standards: Declaration of theme_shoehorn_core_renderer::user_menu() should be compatible with theme_bootstrap_core_renderer::user_menu($user = NULL, $withlinks = NULL) in C:\xampp\htdocs\moodle\theme\shoehorn\renderers\core_renderer.php on line 1034

gjb2048 commented 9 years ago

You have installed the M2.8 version of Bootstrap, please install the M2.7 version. I believe I state on the plugins page. Maybe the Readme is out of date.

Sent from my iPod in deep space...

On 5 Jan 2015, at 08:37, Mike Grant notifications@github.com wrote:

I've just downloaded the latest version for Moodle 2.7 (2.7.1.1) from Moodle.org and installed it for the first time.

Throws a strict standards error with the user menu,

Strict Standards: Declaration of theme_shoehorn_core_renderer::user_menu() should be compatible with theme_bootstrap_core_renderer::user_menu($user = NULL, $withlinks = NULL) in C:\xampp\htdocs\moodle\theme\shoehorn\renderers\core_renderer.php on line 1034

— Reply to this email directly or view it on GitHub.

mike-grant commented 9 years ago

I've double checked the Readme and Moodle.org

Moodle.org is stating that the latest version for 2.7 is 2.7.1.1 and the latest for 2.8 is 2.8.0.1

Thanks

gjb2048 commented 9 years ago

Sorry, I mean the parent Bootstrap theme.

Sent from my iPod in deep space...

On 5 Jan 2015, at 10:15, Mike Grant notifications@github.com wrote:

I've double checked the Readme and Moodle.org

Moodle.org is stating that the latest version for 2.7 is 2.7.1.1 and the latest for 2.8 is 2.8.0.1

Thanks

— Reply to this email directly or view it on GitHub.

gjb2048 commented 9 years ago

Readme states the version of Bootstrap you need: https://github.com/gjb2048/moodle-theme_shoehorn/tree/MOODLE_27#required-version-of-bootstrap-3

gjb2048 commented 9 years ago

Note to self: Needs to be clearer and M2.8 version needs updating in this respect.

gjb2048 commented 9 years ago

Ok, https://moodle.org/plugins/download.php/6987/theme_bootstrap_moodle27_2014100300.zip is unavailable. Humm.

mike-grant commented 9 years ago

I guess this can be closed as an issue really, the issue with the strict standards is caused by me not using the correct versions, so hardly a fault with the theme.

gjb2048 commented 9 years ago

Oh no, it's a version control issue as parent theme is not matching on version and M2.7 version seems to have gone! So, please use the 'Download ZIP' on: https://github.com/gjb2048/theme_bootstrap/tree/master_M27 to get a version that should not have the error.

gjb2048 commented 9 years ago

Fixed in V2.7.1.3, just about to be released.