search

gjbadros / hass-vantage

Home Assistant custom_component for Vantage Infusion Whole House lighting system.
MIT License
9 stars 5 forks source link

Project layout change request #20

Closed ptr727 closed 1 year ago

ptr727 commented 1 year ago

The current project layout does not make a clear separation between custom_components/vantage and the rest of the project.
E.g. copying the project requires hass-vantage to be renamed to vantage as that is what is used to reference the objects in HA.
E.g. the test files, readme, etc., now live in the HA folder.

I suggest you follow the pattern used by other custom components where the project contains a custom_components/vantage directory where only the HA goodies go, and the remainder of the project can be dedicated to boilerplate, graphics, readme, test code, etc.

e.g. see Purple Air and Flair.

gjbadros commented 1 year ago

Is your concern resolved by https://github.com/gjbadros/hass-vantage/pull/16 -- I just merged that.

ptr727 commented 1 year ago

Yes, thank you

stevespaw commented 1 year ago

Does this allow use in HassOS as in https://github.com/gjbadros/hass-vantage/issues/19 ? If so, I am excited to give it a go. Are there new install instructions? Thanks

gjbadros commented 1 year ago

I don't know, give it a try and report back.

On Wed, May 10, 2023, 10:30 AM Steve Spaw @.***> wrote:

Does this allow use in HassOS as in #19 https://github.com/gjbadros/hass-vantage/issues/19 ? If so, I am excited to give it a go. Are there new install instructions? Thanks

— Reply to this email directly, view it on GitHub https://github.com/gjbadros/hass-vantage/issues/20#issuecomment-1542566754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALOHTKJ3ZCXRM7K7BSWPBTXFPGEDANCNFSM6AAAAAAXKBUXD4 . You are receiving this because you commented.Message ID: @.***>

stevespaw commented 1 year ago

I have just looked at, and installed the HACS system in HA. https://hacs.xyz/ This is cool. I was able to integrate my Wyze devices with it. When this Vantage Integration is done, it will be great. https://hacs.xyz/docs/publish/start I assume it is not there yet, since it is not in the repository. I will keep looking for this, Thanks