search

gjbadros / hass-vantage

Home Assistant custom_component for Vantage Infusion Whole House lighting system.
MIT License
9 stars 5 forks source link

Rename disable_cache to enable_cache; change default to disable it. #5

Closed colohan closed 4 years ago

gjbadros commented 4 years ago

Cool... I have a look when at my desk. Thx!

On Fri, Nov 29, 2019, 2:30 PM Chris Colohan notifications@github.com wrote:

@colohan commented on this pull request.

In init.py https://github.com/gjbadros/hass-vantage/pull/5#discussion_r352252085:

@@ -164,7 +164,7 @@ def mappings_from(nm): vc = hass.data[VANTAGE_CONTROLLER]

 await hass.async_add_executor_job(
  • functools.partial(vc.load_xml_db, config.get(CONF_DISABLE_CACHE, False))
  • functools.partial(vc.load_xml_db, config.get(CONF_ENABLE_CACHE, False))

You are right. Serves me right for not testing this code properly. ;-(

Fixed. Also, I patched this into a new client and tested it this time. :-)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gjbadros/hass-vantage/pull/5?email_source=notifications&email_token=AALOHTNBJLU5G5RU3NMUGDLQWGJXRA5CNFSM4JRB3CC2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNOQLQQ#discussion_r352252085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALOHTOOLNSINXRNPTWVQ4LQWGJXRANCNFSM4JRB3CCQ .