search

gjbae1212 / gossm

💻Interactive CLI tool that you can connect to ec2 using commands same as start-session, ssh in AWS SSM Session Manager
MIT License
423 stars 51 forks source link

Possible regression from v1.2.0 onwards when using aws-vault #22

Closed catouc closed 3 years ago

catouc commented 3 years ago

I think I just found a regression from version 1.2.0 onwards when using environment variables for the authentication.

Output with version v1.2.0

[aws:devops-test] [pb:~/Downloads]$ gossm start 
[update] aws ssm plugin
[profile] default
NoCredentialProviders: no valid providers in chain. Deprecated.
    For verbose messaging see aws.Config.CredentialsChainVerboseErrors

Output with version v1.1.1

[aws:devops-test] [pb:~/Downloads]$ gossm start
[update] aws ssm plugin
? Choose a target in AWS:  [Use arrows to move, type to filter]
> xxxxx (i-xxxxxxxxxxxxxxxxxx)
  xxxxx (i-xxxxxxxxxxxxxxxxxx)

Did something major change with the new version?

I've got a fairly basic AWS configuration with aws-vault profile injections

[profile prod]
include_profile=default
source_profile=default
role_arn=arn:aws:iam::0123456789012:role/role-name

[profile test]
include_profile=default
source_profile=default
role_arn=arn:aws:iam::0123456789012:role/role-name

[default]
region=eu-central-1
mfa_serial=arn:aws:iam::0123456789012:mfa/mail@example.com
tedsmitt commented 3 years ago

Hey @Deichindianer, can you try this with version 1.2.3? There was a recent PR to fix the tool using environment variables. See https://github.com/gjbae1212/gossm/issues/17 for the discussion.

catouc commented 3 years ago

Ah sorry, missed that somehow. v1.2.3 fixes the issue :) Thanks for the shout!