search

gjbarnard / moodle-filter_synhi

Syntax highlighter
GNU General Public License v3.0
3 stars 2 forks source link

missing thirdpartylibs.xml #1

Closed danmarsden closed 4 years ago

danmarsden commented 4 years ago

When including an external library in your plugin, you must include a thirdpartylibs.xml file that includes the name, location and license of the library. More information on this is here: https://docs.moodle.org/dev/Plugin_files#thirdpartylibs.xml And here: https://docs.moodle.org/dev/Plugin_with_third_party_libraries

One of the other advantages of using this is that Moodle's codechecker automatically ignores any files included in the location specificed in the thirdpartylibs.xml file.

Please note - this is typically a blocker for approval in the plugins db.

also - this will also allow you to drop this line in your travis config: https://github.com/gjb2048/moodle-filter_synhi/blob/master/.travis.yml#L31

gjb2048 commented 4 years ago

@danmarsden Thank you so much for spotting that, really 'really' appreciated! Gareth