gjbarnard / moodle-filter_synhi

Syntax highlighter
GNU General Public License v3.0
2 stars 2 forks source link

Fixed codechecker problems and added two new settings for EnlighterJS #9

Closed cli-ish closed 1 year ago

cli-ish commented 1 year ago

This PR contains:

If there are any question dont mind to ask :)

gjb2048 commented 1 year ago

Dear @cli-ish,

There are so many things wrong with the changes you're proposing, I almost don't know where to begin, right:

As I'm sure you can now realise, I'm rejecting this! If you submit a patch, please keep it specific to the problem you believe exists, clearly demonstrating what the problem is and why you are solving it.

gjb2048 commented 1 year ago

P.S. If you think I'm being harsh, then I'm not. Attempt to do the same thing with Moodle core code in the Tracker and you'll get the same response. You have to stick to changes that relate directly to the problem. Correcting the style of other people's code is not allowed.

And, additionally, why? Why are you doing this? Why are you spending time on this?