Duplicated section name

gjbarnard / moodle-format_grid

Grid course format contributed by Gareth J Barnard originally created by Paul Krix

GNU General Public License v3.0

21 stars 55 forks source link

Duplicated section name #134

Closed golenkovm closed 3 years ago

golenkovm commented 3 years ago

Hi,

Just found a bug that duplicates a section name in Moodle 3.9.

Steps to replicate:

Create a course with Grid format;
Set layout to one section per page;
Turn editing on;
Move General section into grid;
Open any section.

Screenshot:

Replicated with Moodle 3.9 and master with boost theme.

golenkovm commented 3 years ago

This works fine with Moodle 3.7 and 3.8

golenkovm commented 3 years ago

Hi @gjb2048

I've done some research how does it look like in 3.8 and 3.9.

Moodle 3.8: All sections on one page layout:

Linkable and editable section names with dots.

One section per page layout:

With general section: Not linkable, but editable section name without dots.
Without general section: Not linkable and not editable section name without dots.

Moodle 3.9: All sections on one page layout:

Linkable and editable section names with dots.

One section per page layout:

With general section: Not linkable, but editable section name without dots.
Without general section: (here the bug appears) Not linkable and not editable section name without dots PLUS linkable and editable section names with dots.

From my point of view, not linkable and not editable section name without dots should be removed from one section per page layout with general section moved into grid.

Cheers Mikhail

golenkovm commented 3 years ago

This looks to be a regression of https://github.com/gjb2048/moodle-format_grid/commit/3db48d5d258215ab5b4ec05212d87835053575e6

golenkovm commented 3 years ago

Hey @gjb2048

Could you please have a look at the pull requests that I've created. Feel free to let me know if you think this should be fixed in another way.

Cheers, Mikhail