search

gjbarnard / moodle-format_grid

Grid course format contributed by Gareth J Barnard originally created by Paul Krix
GNU General Public License v3.0
21 stars 55 forks source link

Out of frame pictures in RTL language courses #173

Closed olga0601 closed 1 year ago

olga0601 commented 1 year ago

In RTL language courses new added pictures appear out of frame and located behind the frame.

To Reproduce Steps to reproduce the behavior:

  1. Add a new picture to a section (default pictures look ok)
  2. Change the language to RTL language (arabic or hebrew)
  3. See error - at the courses front page - the pictures that were changed to non-default are located out of their frames.

Expected behavior Pictures to appear inside their frames and above the frame in RTL languages.

*Screenshots English- english RTL language- arabic *

Versions (please complete the following information):

yaakovfendel commented 1 year ago

created pr 174 for fixing the issue the fix in css is :

page-course-view-grid.dir-rtl.format-grid .thegrid .grid-image img {

transform: translate(50%,-50%);

}

gjb2048 commented 1 year ago

@yaakovfendel No that is not the solution as Moodle has RTL CSS flip code that is not working for some reason.

michalwz commented 1 year ago

Hey, I will be happy to know if this will it be fixed any time soon, Thanks

gjb2048 commented 1 year ago

It's on the back log, but won't be fixed soon.