gjbarnard / moodle-format_grid

Grid course format contributed by Gareth J Barnard originally created by Paul Krix
GNU General Public License v3.0
21 stars 55 forks source link

Collapse all button non-responsive with course Edit Mode - WP 4.3.3 #204

Closed jprovasnik closed 3 months ago

jprovasnik commented 6 months ago

I wanted to report a bug where the Collapse All button is not working - the browser URL appends with a # sign, but the course sections do not collapse when this button is clicked, and the text does not change to "Expand all". This is for Moodle Workplace 4.3.3 with the Workplace theme -- I don't know if developers have access to even review issues if it's related Workplace, but figured I share this bug in case it's also happening on the non-workplace version of Moodle 4.3.3 as well.

Steps to reproduce the behaviour:

  1. Open a course that is in Grid format, with editing mode "off"
  2. Click on any section tile to confirm it opens as expected -- close the pop up tile.
  3. Click the "Edit Mode" tile at the top of the page to turn course editing mode "on"
  4. Click the "collapse all" link in the General section
  5. Confirm thee things: (1) the URL now has a "#" at the end, (2) the course sections did not toggle closed, and (3) the "collapse all" link did not change into an "Expand all" link.

Expected behaviour Expected behavior is that upon clicking the "Collapse all" link while in Editing Mode: (1) all course sections wold toggle to a closed state and (2) the "Collapse all" link text would change to "Expand all"

Screenshots This screenshot shows the expected outcome of clicking the "Collapse all" state (minus the fact that it would display "Expand all" if it was used to toggle all sections closed) Screenshot 2024-03-19 at 10 35 50 AM

Versions (please complete the following information):

gjb2048 commented 6 months ago

@jprovasnik Can't replicate in Moodle 4.3.3+ (Build: 20240315) - I don't have access to Moodle Workspace - it's a 'closed shop'.

gjb2048 commented 3 months ago

@jprovasnik No reply, closing.